Re: [Qemu-devel] [Qemu-block] [PATCH] block: fix memory leak in early exit

2015-10-16 Thread Jeff Cody
On Fri, Oct 16, 2015 at 10:37:17AM +0200, Stefan Hajnoczi wrote: > On Fri, Oct 16, 2015 at 08:58:12AM +0200, Alberto Garcia wrote: > > On Thu 15 Oct 2015 05:54:27 PM CEST, Stefan Hajnoczi > > wrote: > > > The stream block job has two early exit code paths. They do not free > > > s->backing_file_

Re: [Qemu-devel] [Qemu-block] [PATCH] block: fix memory leak in early exit

2015-10-16 Thread Stefan Hajnoczi
On Fri, Oct 16, 2015 at 08:58:12AM +0200, Alberto Garcia wrote: > On Thu 15 Oct 2015 05:54:27 PM CEST, Stefan Hajnoczi > wrote: > > The stream block job has two early exit code paths. They do not free > > s->backing_file_str. > > > > Also, the early exits rely on the fact that the coroutine hasn

Re: [Qemu-devel] [Qemu-block] [PATCH] block: fix memory leak in early exit

2015-10-15 Thread Alberto Garcia
On Thu 15 Oct 2015 05:54:27 PM CEST, Stefan Hajnoczi wrote: > The stream block job has two early exit code paths. They do not free > s->backing_file_str. > > Also, the early exits rely on the fact that the coroutine hasn't yielded > yet and was launched from the main thread. Therefore the corou