Re: [Qemu-devel] [Qemu-block] [PATCH] block: clarify error message for qmp-eject

2016-05-19 Thread Markus Armbruster
John Snow writes: > On 05/18/2016 01:36 AM, Markus Armbruster wrote: >> Fam Zheng writes: >> >>> On Tue, 05/17 20:42, John Snow wrote: If you use HMP's eject but the CDROM tray is locked, you may get a confusing error message informing you that the "tray isn't open." As this

Re: [Qemu-devel] [Qemu-block] [PATCH] block: clarify error message for qmp-eject

2016-05-18 Thread John Snow
On 05/18/2016 01:36 AM, Markus Armbruster wrote: > Fam Zheng writes: > >> On Tue, 05/17 20:42, John Snow wrote: >>> If you use HMP's eject but the CDROM tray is locked, you may get a >>> confusing error message informing you that the "tray isn't open." >>> >>> As this is the point of eject, we

Re: [Qemu-devel] [Qemu-block] [PATCH] block: clarify error message for qmp-eject

2016-05-18 Thread John Snow
On 05/18/2016 02:36 AM, Fam Zheng wrote: > On Wed, 05/18 07:36, Markus Armbruster wrote: >> Fam Zheng writes: >> >>> On Tue, 05/17 20:42, John Snow wrote: If you use HMP's eject but the CDROM tray is locked, you may get a confusing error message informing you that the "tray isn't open.

Re: [Qemu-devel] [Qemu-block] [PATCH] block: clarify error message for qmp-eject

2016-05-18 Thread Markus Armbruster
Fam Zheng writes: > On Wed, 05/18 07:36, Markus Armbruster wrote: >> Fam Zheng writes: >> >> > On Tue, 05/17 20:42, John Snow wrote: >> >> If you use HMP's eject but the CDROM tray is locked, you may get a >> >> confusing error message informing you that the "tray isn't open." >> >> >> >> As t

Re: [Qemu-devel] [Qemu-block] [PATCH] block: clarify error message for qmp-eject

2016-05-17 Thread Fam Zheng
On Wed, 05/18 07:36, Markus Armbruster wrote: > Fam Zheng writes: > > > On Tue, 05/17 20:42, John Snow wrote: > >> If you use HMP's eject but the CDROM tray is locked, you may get a > >> confusing error message informing you that the "tray isn't open." > >> > >> As this is the point of eject, we

Re: [Qemu-devel] [Qemu-block] [PATCH] block: clarify error message for qmp-eject

2016-05-17 Thread Markus Armbruster
Fam Zheng writes: > On Tue, 05/17 20:42, John Snow wrote: >> If you use HMP's eject but the CDROM tray is locked, you may get a >> confusing error message informing you that the "tray isn't open." >> >> As this is the point of eject, we can do a little better and help >> clarify that the tray wa

Re: [Qemu-devel] [Qemu-block] [PATCH] block: clarify error message for qmp-eject

2016-05-17 Thread Eric Blake
On 05/17/2016 08:18 PM, Fam Zheng wrote: > On Tue, 05/17 20:42, John Snow wrote: >> If you use HMP's eject but the CDROM tray is locked, you may get a >> confusing error message informing you that the "tray isn't open." >> >> As this is the point of eject, we can do a little better and help >> clar