Re: [Qemu-devel] [Qemu-arm] [PATCH] highbank: validate register offset before access

2017-11-11 Thread P J P
Hello Philippe, +-- On Fri, 10 Nov 2017, Philippe Mathieu-Daudé wrote --+ | I'd report that: | |qemu_log_mask(LOG_UNIMP, ... | | Cc'ing Shawn & Rob since this might also be a LOG_GUEST_ERROR. | | Mixed declarations (interleaving statements and declarations within | blocks) are gen

Re: [Qemu-devel] [Qemu-arm] [PATCH] highbank: validate register offset before access

2017-11-10 Thread Philippe Mathieu-Daudé
Hi Prasad, Moguofang. On 11/09/2017 08:58 AM, P J P wrote: > From: Prasad J Pandit > > An 'offset' parameter sent to highbank register r/w functions > could be greater than number(NUM_REGS=0x200) of hb registers, > leading to an OOB access issue. Add check to avoid it. > > Reported-by: Moguofan