Re: [Qemu-devel] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-13 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 10/12/2016 04:59 PM, Dr. David Alan Gilbert wrote: > >> Paolo I agree on a theoretical level. It's just I do not see why this > >> > particular change makes the API simpler. In my opinion this complicates > >> > things because now all VMSta

Re: [Qemu-devel] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-13 Thread Halil Pasic
On 10/12/2016 04:59 PM, Dr. David Alan Gilbert wrote: >> Paolo I agree on a theoretical level. It's just I do not see why this >> > particular change makes the API simpler. In my opinion this complicates >> > things because now all VMStateInfo's can do funky stuff. Having additional >> > state yo

Re: [Qemu-devel] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-12 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 10/12/2016 02:07 PM, Paolo Bonzini wrote: > > > > On 12/10/2016 13:59, Halil Pasic wrote: > >> > IMHO this would: > >> > * allow us to keep the good old MVStateInfo objects unmodified and > >> > the semantic of VMStateInfo unchanged > >>

Re: [Qemu-devel] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-12 Thread Halil Pasic
On 10/12/2016 02:07 PM, Paolo Bonzini wrote: > > On 12/10/2016 13:59, Halil Pasic wrote: >> > IMHO this would: >> > * allow us to keep the good old MVStateInfo objects unmodified and >> > the semantic of VMStateInfo unchanged >> > * make clear that VMStateLinked does not care about the calcula

Re: [Qemu-devel] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-12 Thread Paolo Bonzini
On 12/10/2016 13:59, Halil Pasic wrote: > IMHO this would: > * allow us to keep the good old MVStateInfo objects unmodified and > the semantic of VMStateInfo unchanged > * make clear that VMStateLinked does not care about the calculated size > and provide a new anchor for documentation > * if

Re: [Qemu-devel] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-12 Thread Halil Pasic
On 10/03/2016 08:24 PM, Jianjun Duan wrote: > Current migration code cannot handle some data structures such as > QTAILQ in qemu/queue.h. Here we extend the signatures of put/get > in VMStateInfo so that customized handling is supported. > > Signed-off-by: Jianjun Duan > --- > hw/net/vmxnet3.c

Re: [Qemu-devel] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-07 Thread Dr. David Alan Gilbert
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > Current migration code cannot handle some data structures such as > QTAILQ in qemu/queue.h. Here we extend the signatures of put/get > in VMStateInfo so that customized handling is supported. > > Signed-off-by: Jianjun Duan > --- > hw/net/vmxnet

[Qemu-devel] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-03 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. Signed-off-by: Jianjun Duan --- hw/net/vmxnet3.c| 18 ++--- hw/nvram/eeprom93xx.c | 6