Re: [Qemu-devel] [QEMU PATCH] create struct for machine initialization arguments (v2)

2012-10-05 Thread Eric Blake
On 10/05/2012 02:40 PM, Eduardo Habkost wrote: >>> -machine->init(ram_size, boot_devices, >>> - kernel_filename, kernel_cmdline, initrd_filename, >>> cpu_model); >>> +QEMUMachineInitArgs args = { .ram_size = ram_size, >>> + .boot_device = b

Re: [Qemu-devel] [QEMU PATCH] create struct for machine initialization arguments (v2)

2012-10-05 Thread Eduardo Habkost
On Sat, Oct 06, 2012 at 12:33:09AM +0400, Max Filippov wrote: > On Sat, Oct 6, 2012 at 12:22 AM, Eduardo Habkost wrote: > > This should help us to: > > - More easily add or remove machine initialization arguments without > > having to change every single machine init function; > > - More easily

Re: [Qemu-devel] [QEMU PATCH] create struct for machine initialization arguments (v2)

2012-10-05 Thread Max Filippov
On Sat, Oct 6, 2012 at 12:22 AM, Eduardo Habkost wrote: > This should help us to: > - More easily add or remove machine initialization arguments without > having to change every single machine init function; > - More easily make mechanical changes involving the machine init > functions in the

Re: [Qemu-devel] [QEMU PATCH] create struct for machine initialization arguments

2012-10-05 Thread Eduardo Habkost
On Fri, Oct 05, 2012 at 03:37:00PM -0300, Eduardo Habkost wrote: [...] > diff --git a/hw/boards.h b/hw/boards.h > index a2e0a54..813d0e5 100644 > --- a/hw/boards.h > +++ b/hw/boards.h > @@ -5,12 +5,16 @@ > > #include "qdev.h" > > -typedef void QEMUMachineInitFunc(ram_addr_t ram_size, > -