Re: [Qemu-devel] [Patch V0] x86, mce: Basic support to add LMCE support to QEMU

2015-12-09 Thread Raj, Ashok
On Wed, Dec 09, 2015 at 10:07:48PM +0100, Paolo Bonzini wrote: > > > On 09/12/2015 20:57, Ashok Raj wrote: > > +/* > > + * We need to read back the value of MSREXT_MCG_CTL that was set by the > > + * guest kernel back into Qemu > > + */ > > +cs->kvm_vcpu_dirty = false; > > +

[Qemu-devel] [Patch V0] x86, mce: Basic support to add LMCE support to QEMU

2015-12-09 Thread Ashok Raj
This patch adds basic enumeration, control msr's required to support Local Machine Check Exception Support (LMCE). - Added Local Machine Check definitions, changed MCG_CAP - Added support for IA32_FEATURE_CONTROL. - When delivering MCE to guest, we deliver to just a single CPU when guest OS has

Re: [Qemu-devel] [Patch V0] x86, mce: Basic support to add LMCE support to QEMU

2015-12-09 Thread Paolo Bonzini
On 10/12/2015 00:05, Raj, Ashok wrote: >>> > > +/* >>> > > + * We need to read back the value of MSREXT_MCG_CTL that was set >>> > > by the >>> > > + * guest kernel back into Qemu >>> > > + */ >>> > > +cs->kvm_vcpu_dirty = false; >>> > > +cpu_synchronize_state(cs); > This

Re: [Qemu-devel] [Patch V0] x86, mce: Basic support to add LMCE support to QEMU

2015-12-09 Thread Paolo Bonzini
On 09/12/2015 20:57, Ashok Raj wrote: > +/* > + * We need to read back the value of MSREXT_MCG_CTL that was set by the > + * guest kernel back into Qemu > + */ > +cs->kvm_vcpu_dirty = false; > +cpu_synchronize_state(cs); This should not be necessary. I've only skimmed th