Re: [Qemu-devel] [Patch] siginfo fix for Darwin/Mac OS X

2007-01-24 Thread Fabrice Bellard
Hi, I agree that your solution with 'void *' is better than the current one. Fabrice. Pierre d'Herbemont wrote: Hi, This patch is an attempt to suppress the anonymous "struct siginfo" trick, as it doesn't work on darwin since struct siginfo isn't defined, and stay anonymous. Here I use

[Qemu-devel] [Patch] siginfo fix for Darwin/Mac OS X

2007-01-24 Thread Pierre d'Herbemont
Hi, This patch is an attempt to suppress the anonymous "struct siginfo" trick, as it doesn't work on darwin since struct siginfo isn't defined, and stay anonymous. Here I use siginfo_t, assuming that it is defined on most platform. But feel free to add a "typedef struct siginfo siginfo_t;

Re: [Qemu-devel] [PATCH] siginfo fix for Darwin/Mac OS X on PowerPC and cleanup

2007-01-18 Thread Pierre d'Herbemont
On 18 janv. 07, at 23:57, Thiemo Seufer wrote: It might be better to keep the full set around for documentation. It's a good point. -int cpu_signal_handler(int host_signum, struct siginfo *info, +int cpu_signal_handler(int host_signum, struct siginfo *pinfo, void *p

Re: [Qemu-devel] [PATCH] siginfo fix for Darwin/Mac OS X on PowerPC and cleanup

2007-01-18 Thread Thiemo Seufer
Pierre d'Herbemont wrote: > Hi, > > This patch addresses cpu-exec.c compilation on Mac OS X/ppc. It also > cleans up unused Macro definition. > > Pierre. > Index: cpu-exec.c > === > RCS file: /sources/qemu/qemu/cpu-exec.c,v > retr

[Qemu-devel] [PATCH] siginfo fix for Darwin/Mac OS X on PowerPC and cleanup

2007-01-18 Thread Pierre d'Herbemont
Hi, This patch addresses cpu-exec.c compilation on Mac OS X/ppc. It also cleans up unused Macro definition. Pierre. Index: cpu-exec.c === RCS file: /sources/qemu/qemu/cpu-exec.c,v retrieving revision 1.88 diff -u -r1.88 cpu-exec.