Re: [Qemu-devel] [PULL v4 08/12] target-lm32: add breakpoint/watchpoint support

2014-02-03 Thread Peter Maydell
On 3 February 2014 21:27, Richard Henderson wrote: > On 02/01/2014 10:16 AM, Peter Maydell wrote: >> This looks at least superficially OK, but I'm not really familiar >> with QEMU's breakpoint/watchpoint support code. RTH: do >> you want to have a look over this one? > > It's copied verbatim from

Re: [Qemu-devel] [PULL v4 08/12] target-lm32: add breakpoint/watchpoint support

2014-02-03 Thread Richard Henderson
On 02/01/2014 10:16 AM, Peter Maydell wrote: > This looks at least superficially OK, but I'm not really familiar > with QEMU's breakpoint/watchpoint support code. RTH: do > you want to have a look over this one? It's copied verbatim from the i386 port, missing braces and all. So it certainly passe

Re: [Qemu-devel] [PULL v4 08/12] target-lm32: add breakpoint/watchpoint support

2014-02-01 Thread Peter Maydell
On 20 January 2014 19:34, Michael Walle wrote: > This patch adds in-target breakpoint and watchpoint support. This looks at least superficially OK, but I'm not really familiar with QEMU's breakpoint/watchpoint support code. RTH: do you want to have a look over this one? A style point, since I'm

[Qemu-devel] [PULL v4 08/12] target-lm32: add breakpoint/watchpoint support

2014-01-20 Thread Michael Walle
This patch adds in-target breakpoint and watchpoint support. Signed-off-by: Michael Walle --- target-lm32/TODO|2 -- target-lm32/cpu.c |1 + target-lm32/cpu.h | 27 -- target-lm32/helper.c| 89 +++ target