Re: [Qemu-devel] [PULL v2 3/3] blockdev: acquire aio_context for bitmap add/remove

2019-05-31 Thread John Snow
On 5/31/19 3:01 PM, Vladimir Sementsov-Ogievskiy wrote: > 31.05.2019 21:16, John Snow wrote: >> >> >> On 5/31/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi! >>> >>> 20.02.2019 21:01, John Snow wrote: When bitmaps are persistent, they may incur a disk read or write when bitmap

Re: [Qemu-devel] [PULL v2 3/3] blockdev: acquire aio_context for bitmap add/remove

2019-05-31 Thread Vladimir Sementsov-Ogievskiy
31.05.2019 21:16, John Snow wrote: > > > On 5/31/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: >> Hi! >> >> 20.02.2019 21:01, John Snow wrote: >>> When bitmaps are persistent, they may incur a disk read or write when >>> bitmaps >>> are added or removed. For configurations like virtio-dataplan

Re: [Qemu-devel] [PULL v2 3/3] blockdev: acquire aio_context for bitmap add/remove

2019-05-31 Thread John Snow
On 5/31/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > 20.02.2019 21:01, John Snow wrote: >> When bitmaps are persistent, they may incur a disk read or write when bitmaps >> are added or removed. For configurations like virtio-dataplane, failing to >> acquire this lock will abort QEM

Re: [Qemu-devel] [PULL v2 3/3] blockdev: acquire aio_context for bitmap add/remove

2019-05-31 Thread Vladimir Sementsov-Ogievskiy
Hi! 20.02.2019 21:01, John Snow wrote: > When bitmaps are persistent, they may incur a disk read or write when bitmaps > are added or removed. For configurations like virtio-dataplane, failing to > acquire this lock will abort QEMU when disk IO occurs. > > We used to acquire aio_context as part o

[Qemu-devel] [PULL v2 3/3] blockdev: acquire aio_context for bitmap add/remove

2019-02-20 Thread John Snow
When bitmaps are persistent, they may incur a disk read or write when bitmaps are added or removed. For configurations like virtio-dataplane, failing to acquire this lock will abort QEMU when disk IO occurs. We used to acquire aio_context as part of the bitmap lookup, so re-introduce the lock for