Re: [Qemu-devel] [PULL v2 18/32] qmp: Don't let JSON errors jump the queue

Kevin Wolf writes: > Am 10.07.2018 um 16:02 hat Marc-André Lureau geschrieben: >> Hi >> >> On Tue, Jul 10, 2018 at 3:20 PM, Kevin Wolf wrote: >> > Am 03.07.2018 um 23:35 hat Markus Armbruster geschrieben: >> >> handle_qmp_command() reports JSON syntax errors right away. This is >> >> wrong whe

Re: [Qemu-devel] [PULL v2 18/32] qmp: Don't let JSON errors jump the queue

Am 10.07.2018 um 16:02 hat Marc-André Lureau geschrieben: > Hi > > On Tue, Jul 10, 2018 at 3:20 PM, Kevin Wolf wrote: > > Am 03.07.2018 um 23:35 hat Markus Armbruster geschrieben: > >> handle_qmp_command() reports JSON syntax errors right away. This is > >> wrong when OOB is enabled, because the

Re: [Qemu-devel] [PULL v2 18/32] qmp: Don't let JSON errors jump the queue

Hi On Tue, Jul 10, 2018 at 3:20 PM, Kevin Wolf wrote: > Am 03.07.2018 um 23:35 hat Markus Armbruster geschrieben: >> handle_qmp_command() reports JSON syntax errors right away. This is >> wrong when OOB is enabled, because the errors can "jump the queue" >> then. >> >> The previous commit fixed

Re: [Qemu-devel] [PULL v2 18/32] qmp: Don't let JSON errors jump the queue

Am 03.07.2018 um 23:35 hat Markus Armbruster geschrieben: > handle_qmp_command() reports JSON syntax errors right away. This is > wrong when OOB is enabled, because the errors can "jump the queue" > then. > > The previous commit fixed the same bug for semantic errors, by > delaying the checking u

[Qemu-devel] [PULL v2 18/32] qmp: Don't let JSON errors jump the queue

handle_qmp_command() reports JSON syntax errors right away. This is wrong when OOB is enabled, because the errors can "jump the queue" then. The previous commit fixed the same bug for semantic errors, by delaying the checking until dispatch. We can't delay the checking, so delay the reporting.