Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

2014-04-08 Thread Michael Tokarev
08.04.2014 14:57, Markus Armbruster wrote: > Peter Maydell writes: > >> On 8 April 2014 09:52, Michael Tokarev wrote: >>> Well. At least one of them is entirely safe (hw/ide/ahci.c). >>> Another - xbzrle.c - looks okay, and even maybe fixing a bug. >>> And this int128 thing is okay too, except

Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

2014-04-08 Thread Markus Armbruster
Peter Maydell writes: > On 8 April 2014 09:52, Michael Tokarev wrote: >> Well. At least one of them is entirely safe (hw/ide/ahci.c). >> Another - xbzrle.c - looks okay, and even maybe fixing a bug. >> And this int128 thing is okay too, except that the whole thing >> is questionable as has been

Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

2014-04-08 Thread Peter Maydell
On 8 April 2014 09:52, Michael Tokarev wrote: > Well. At least one of them is entirely safe (hw/ide/ahci.c). > Another - xbzrle.c - looks okay, and even maybe fixing a bug. > And this int128 thing is okay too, except that the whole thing > is questionable as has been mentioned in that thread. > >

Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

2014-04-08 Thread Michael Tokarev
08.04.2014 12:10, Peter Maydell wrote: > On 8 April 2014 08:04, Michael Tokarev wrote: >> And there's a series of 3 patches by Peter Maydell which adds casts >> to uint* in a few places. Those are also quite simple and safe, even >> with quite some disagreement about whenever this is necessary to

Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

2014-04-08 Thread Peter Maydell
On 8 April 2014 08:04, Michael Tokarev wrote: > And there's a series of 3 patches by Peter Maydell which adds casts > to uint* in a few places. Those are also quite simple and safe, even > with quite some disagreement about whenever this is necessary to > start with -- I mean the int128 change, t

[Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

2014-04-08 Thread Michael Tokarev
This is the last-minute trivial-patches tree. We're very close to release now, and here are mostly doc/comment/identation fixes which are safe even at this stage of the release process. There's also addition of the coverity model which does not affect code in any way. And there's a series of 3 p