Re: [Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test

2018-10-29 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Oct 9, 2018 at 8:41 PM Markus Armbruster wrote: >> >> Markus Armbruster writes: >> >> > Thomas Huth writes: >> > >> >> On 2018-08-31 15:24, Marc-André Lureau wrote: [...] >> >>> Tbh, I don't care so much about the naming of the test, but (for once) >>

Re: [Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test

2018-10-28 Thread Marc-André Lureau
Hi On Tue, Oct 9, 2018 at 8:41 PM Markus Armbruster wrote: > > Markus Armbruster writes: > > > Thomas Huth writes: > > > >> On 2018-08-31 15:24, Marc-André Lureau wrote: > >>> Hi > >>> On Fri, Aug 31, 2018 at 3:18 PM Thomas Huth wrote: > > On 2018-08-31 14:04, Markus Armbruster wrote

Re: [Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test

2018-10-09 Thread Markus Armbruster
Markus Armbruster writes: > Thomas Huth writes: > >> On 2018-08-31 15:24, Marc-André Lureau wrote: >>> Hi >>> On Fri, Aug 31, 2018 at 3:18 PM Thomas Huth wrote: On 2018-08-31 14:04, Markus Armbruster wrote: > Thomas Huth writes: > >> From: Marc-André Lureau >> >>

Re: [Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test

2018-09-02 Thread Thomas Huth
On 2018-08-31 16:35, Markus Armbruster wrote: > Thomas Huth writes: > >> On 2018-08-31 15:24, Marc-André Lureau wrote: >>> Hi >>> On Fri, Aug 31, 2018 at 3:18 PM Thomas Huth wrote: On 2018-08-31 14:04, Markus Armbruster wrote: > Thomas Huth writes: > >> From: Marc-André Lu

Re: [Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test

2018-08-31 Thread Markus Armbruster
Thomas Huth writes: > On 2018-08-31 15:24, Marc-André Lureau wrote: >> Hi >> On Fri, Aug 31, 2018 at 3:18 PM Thomas Huth wrote: >>> >>> On 2018-08-31 14:04, Markus Armbruster wrote: Thomas Huth writes: > From: Marc-André Lureau > > test_qom_set_without_value() is about a

Re: [Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test

2018-08-31 Thread Marc-André Lureau
Hi On Fri, Aug 31, 2018 at 3:18 PM Thomas Huth wrote: > > On 2018-08-31 14:04, Markus Armbruster wrote: > > Thomas Huth writes: > > > >> From: Marc-André Lureau > >> > >> test_qom_set_without_value() is about a bug in infrastructure used by > >> the QMP core, fixed in commit c489780203. We cove

Re: [Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test

2018-08-31 Thread Thomas Huth
On 2018-08-31 15:24, Marc-André Lureau wrote: > Hi > On Fri, Aug 31, 2018 at 3:18 PM Thomas Huth wrote: >> >> On 2018-08-31 14:04, Markus Armbruster wrote: >>> Thomas Huth writes: >>> From: Marc-André Lureau test_qom_set_without_value() is about a bug in infrastructure used by >>>

Re: [Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test

2018-08-31 Thread Thomas Huth
On 2018-08-31 14:04, Markus Armbruster wrote: > Thomas Huth writes: > >> From: Marc-André Lureau >> >> test_qom_set_without_value() is about a bug in infrastructure used by >> the QMP core, fixed in commit c489780203. We covered the bug in >> infrastructure unit tests (commit bce3035a44). I wr

Re: [Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test

2018-08-31 Thread Markus Armbruster
Thomas Huth writes: > From: Marc-André Lureau > > test_qom_set_without_value() is about a bug in infrastructure used by > the QMP core, fixed in commit c489780203. We covered the bug in > infrastructure unit tests (commit bce3035a44). I wrote that test > earlier, to cover QMP level as well, th

[Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test

2018-08-31 Thread Thomas Huth
From: Marc-André Lureau test_qom_set_without_value() is about a bug in infrastructure used by the QMP core, fixed in commit c489780203. We covered the bug in infrastructure unit tests (commit bce3035a44). I wrote that test earlier, to cover QMP level as well, the test could go into qmp-test. S