Re: [Qemu-devel] [PULL 6/6] Monitor: Make output buffer dynamic

2013-04-02 Thread Luiz Capitulino
On Tue, 02 Apr 2013 10:50:49 -0500 Anthony Liguori wrote: > Luiz Capitulino writes: > > > On Tue, 2 Apr 2013 10:37:01 -0400 > > Luiz Capitulino wrote: > > > >> On Mon, 01 Apr 2013 10:35:34 -0500 > >> Anthony Liguori wrote: > >> > >> > Luiz Capitulino writes: > >> > > >> > > Commit f628926b

Re: [Qemu-devel] [PULL 6/6] Monitor: Make output buffer dynamic

2013-04-02 Thread Anthony Liguori
Luiz Capitulino writes: > On Tue, 2 Apr 2013 10:37:01 -0400 > Luiz Capitulino wrote: > >> On Mon, 01 Apr 2013 10:35:34 -0500 >> Anthony Liguori wrote: >> >> > Luiz Capitulino writes: >> > >> > > Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush() >> > > to retry on qemu_c

Re: [Qemu-devel] [PULL 6/6] Monitor: Make output buffer dynamic

2013-04-02 Thread Luiz Capitulino
On Tue, 2 Apr 2013 10:37:01 -0400 Luiz Capitulino wrote: > On Mon, 01 Apr 2013 10:35:34 -0500 > Anthony Liguori wrote: > > > Luiz Capitulino writes: > > > > > Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush() > > > to retry on qemu_chr_fe_write() errors. However, the Mon

Re: [Qemu-devel] [PULL 6/6] Monitor: Make output buffer dynamic

2013-04-02 Thread Luiz Capitulino
On Mon, 01 Apr 2013 10:35:34 -0500 Anthony Liguori wrote: > Luiz Capitulino writes: > > > Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush() > > to retry on qemu_chr_fe_write() errors. However, the Monitor's output > > buffer can keep growing while the retry is not issued a

Re: [Qemu-devel] [PULL 6/6] Monitor: Make output buffer dynamic

2013-04-01 Thread Anthony Liguori
Luiz Capitulino writes: > Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush() > to retry on qemu_chr_fe_write() errors. However, the Monitor's output > buffer can keep growing while the retry is not issued and this can > cause the buffer to overflow. > > To reproduce this issu

[Qemu-devel] [PULL 6/6] Monitor: Make output buffer dynamic

2013-03-27 Thread Luiz Capitulino
Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush() to retry on qemu_chr_fe_write() errors. However, the Monitor's output buffer can keep growing while the retry is not issued and this can cause the buffer to overflow. To reproduce this issue, just start qemu and type on the Mo