Re: [Qemu-devel] [PULL 40/96] virtio-scsi: use standard-headers

2015-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 10:48:27AM +0100, Paolo Bonzini wrote: > > > On 11/03/2015 09:31, Michael S. Tsirkin wrote: > > On Wed, Mar 11, 2015 at 03:14:16PM +0800, Fam Zheng wrote: > >> On Wed, 02/18 22:48, Michael S. Tsirkin wrote: > >>> Drop duplicated code. > >>> > >>> Signed-off-by: Michael S.

Re: [Qemu-devel] [PULL 40/96] virtio-scsi: use standard-headers

2015-03-11 Thread Paolo Bonzini
On 11/03/2015 09:31, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2015 at 03:14:16PM +0800, Fam Zheng wrote: >> On Wed, 02/18 22:48, Michael S. Tsirkin wrote: >>> Drop duplicated code. >>> >>> Signed-off-by: Michael S. Tsirkin >>> Acked-by: Paolo Bonzini >> >> Michael, this breaks virtio-scsi-pc

Re: [Qemu-devel] [PULL 40/96] virtio-scsi: use standard-headers

2015-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 03:14:16PM +0800, Fam Zheng wrote: > On Wed, 02/18 22:48, Michael S. Tsirkin wrote: > > Drop duplicated code. > > > > Signed-off-by: Michael S. Tsirkin > > Acked-by: Paolo Bonzini > > Michael, this breaks virtio-scsi-pci: > > qemu-system-x86_64: wrong size for virti

Re: [Qemu-devel] [PULL 40/96] virtio-scsi: use standard-headers

2015-03-11 Thread Fam Zheng
On Wed, 02/18 22:48, Michael S. Tsirkin wrote: > Drop duplicated code. > > Signed-off-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini Michael, this breaks virtio-scsi-pci: qemu-system-x86_64: wrong size for virtio-scsi headers Because: > - > -/* SCSI command request, followed by CDB and

[Qemu-devel] [PULL 40/96] virtio-scsi: use standard-headers

2015-02-18 Thread Michael S. Tsirkin
Drop duplicated code. Signed-off-by: Michael S. Tsirkin Acked-by: Paolo Bonzini --- include/hw/virtio/virtio-scsi.h | 120 +++- hw/scsi/virtio-scsi.c | 1 + 2 files changed, 10 insertions(+), 111 deletions(-) diff --git a/include/hw/virtio/virtio