Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-29 Thread Anthony Liguori
On 05/22/2012 07:25 AM, Paolo Bonzini wrote: The following changes since commit 76ee152a86d5f2533443ce4d2be6fe253cfb3c45: Update version to 1.1.0-rc2 (2012-05-14 17:56:50 -0500) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at: git://github.com/bonzi

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-29 Thread Paolo Bonzini
Il 29/05/2012 11:15, Anthony Liguori ha scritto: >>> >>> >>> It all looks good as long as you apply the patch to #include >>> "hw/scsi-defs.h" >> >> Thanks, I updated the scsi-next branch. > > So should I expect a new branch for this pull? No, same branch, one more patch. I just sent the pull re

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-29 Thread Anthony Liguori
On 05/28/2012 01:46 AM, Paolo Bonzini wrote: Il 26/05/2012 11:18, ronnie sahlberg ha scritto: I have compiled your branch and run through some tests. It all looks good as long as you apply the patch to #include "hw/scsi-defs.h" Thanks, I updated the scsi-next branch. So should I expect a ne

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-27 Thread Paolo Bonzini
Il 26/05/2012 11:18, ronnie sahlberg ha scritto: > I have compiled your branch and run through some tests. > > It all looks good as long as you apply the patch to #include "hw/scsi-defs.h" Thanks, I updated the scsi-next branch. Paolo

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-26 Thread ronnie sahlberg
I have compiled your branch and run through some tests. It all looks good as long as you apply the patch to #include "hw/scsi-defs.h" On Sat, May 26, 2012 at 6:17 PM, ronnie sahlberg wrote: > Im compiling your branch now and will verify all is good. > > It is missing an include  so you need to

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-26 Thread ronnie sahlberg
Im compiling your branch now and will verify all is good. It is missing an include so you need to add this patch to compile : On Sat, May 26, 2012 at 5:59 PM, ronnie sahlberg wrote: > Almost, > but connecter=1 should be set after the if statement not inside it. > >     if (status != 0) { > +

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-26 Thread ronnie sahlberg
Almost, but connecter=1 should be set after the if statement not inside it. if (status != 0) { +itask->iscsilun->connected = 1; itask->status = 1; I.e. dont set it in the error path, set it after the block. then it should be all good. optionally you can revert 5b5e96bba

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-26 Thread Paolo Bonzini
Il 26/05/2012 07:41, ronnie sahlberg ha scritto: > Paolo, > > You need this patch too since without it it might crash. > > commit 6e46eb1846a862dad253be1a576f8554071b154a > Author: Ronnie Sahlberg > Date: Sat May 26 10:28:05 2012 +1000 > > ISCSI: We can only do the shortcircuit and write

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-25 Thread ronnie sahlberg
Paolo, You need this patch too since without it it might crash. commit 6e46eb1846a862dad253be1a576f8554071b154a Author: Ronnie Sahlberg Date: Sat May 26 10:28:05 2012 +1000 ISCSI: We can only do the shortcircuit and write directly to the socket IFF we know the socket is open (and writ

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-25 Thread Paolo Bonzini
Il 22/05/2012 14:25, Paolo Bonzini ha scritto: > The following changes since commit 76ee152a86d5f2533443ce4d2be6fe253cfb3c45: > > Update version to 1.1.0-rc2 (2012-05-14 17:56:50 -0500) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git scsi-next > > for you t

[Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-22 Thread Paolo Bonzini
The following changes since commit 76ee152a86d5f2533443ce4d2be6fe253cfb3c45: Update version to 1.1.0-rc2 (2012-05-14 17:56:50 -0500) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up to e1a2d34f4abd8a117f5c5a25a5bb2e67d597de23: