Re: [Qemu-devel] [PULL 1/1] spice: auth fixes

2014-07-11 Thread Markus Armbruster
Peter Maydell writes: > On 11 July 2014 12:18, Markus Armbruster wrote: >> Gerd Hoffmann writes: >> >>> Set auth to sasl when sasl is enabled, this makes "info spice" correctly >>> display sasl auth. >> >> Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it? >> >> If yes, I'd recommend to

Re: [Qemu-devel] [PULL 1/1] spice: auth fixes

2014-07-11 Thread Peter Maydell
On 11 July 2014 12:18, Markus Armbruster wrote: > Gerd Hoffmann writes: > >> Set auth to sasl when sasl is enabled, this makes "info spice" correctly >> display sasl auth. > > Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it? > > If yes, I'd recommend to note this in the commit message.

Re: [Qemu-devel] [PULL 1/1] spice: auth fixes

2014-07-11 Thread Markus Armbruster
Gerd Hoffmann writes: > Set auth to sasl when sasl is enabled, this makes "info spice" correctly > display sasl auth. Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it? If yes, I'd recommend to note this in the commit message. > Also throw an error in case someone t

[Qemu-devel] [PULL 1/1] spice: auth fixes

2014-07-11 Thread Gerd Hoffmann
Set auth to sasl when sasl is enabled, this makes "info spice" correctly display sasl auth. Also throw an error in case someone tries to set a spice password via monitor without auth mode being "spice". Signed-off-by: Gerd Hoffmann --- ui/spice-core.c | 5 + 1 file changed, 5 insertions(+)