Re: [Qemu-devel] [PULL 08/11] linux-user: Check for cpu_init() errors

2015-02-27 Thread Eduardo Habkost
On Fri, Feb 27, 2015 at 08:23:12AM +0900, Peter Maydell wrote: > On 27 February 2015 at 08:11, Eduardo Habkost wrote: > > On Fri, Feb 27, 2015 at 08:00:25AM +0900, Peter Maydell wrote: > >> On 27 February 2015 at 07:51, Eduardo Habkost wrote: > >> > I have never seen it in practice, but in x86 it

Re: [Qemu-devel] [PULL 08/11] linux-user: Check for cpu_init() errors

2015-02-26 Thread Eduardo Habkost
On Fri, Feb 27, 2015 at 08:00:25AM +0900, Peter Maydell wrote: > On 27 February 2015 at 07:51, Eduardo Habkost wrote: > > On Fri, Feb 27, 2015 at 07:44:29AM +0900, Peter Maydell wrote: > >> When can it actually fail? Have you seen it do this in practice? > >> (Note that this is only called from fo

Re: [Qemu-devel] [PULL 08/11] linux-user: Check for cpu_init() errors

2015-02-26 Thread Eduardo Habkost
On Fri, Feb 27, 2015 at 07:44:29AM +0900, Peter Maydell wrote: > On 27 February 2015 at 01:06, Eduardo Habkost wrote: > > On Thu, Feb 26, 2015 at 08:27:12AM +0900, Peter Maydell wrote: > >> Rather than bailing out here, it would be better to > >> propagate the failure out to the caller, which can

Re: [Qemu-devel] [PULL 08/11] linux-user: Check for cpu_init() errors

2015-02-26 Thread Peter Maydell
On 27 February 2015 at 01:06, Eduardo Habkost wrote: > On Thu, Feb 26, 2015 at 08:27:12AM +0900, Peter Maydell wrote: >> Rather than bailing out here, it would be better to >> propagate the failure out to the caller, which can >> then fail the fork syscall it's trying to emulate >> by returning a

Re: [Qemu-devel] [PULL 08/11] linux-user: Check for cpu_init() errors

2015-02-26 Thread Eduardo Habkost
On Thu, Feb 26, 2015 at 08:27:12AM +0900, Peter Maydell wrote: > On 26 February 2015 at 04:58, Eduardo Habkost wrote: > > This was the only caller of cpu_init() that was not checking for NULL > > yet. > > > > Reviewed-by: Paolo Bonzini > > Signed-off-by: Eduardo Habkost > > --- > > linux-user/m

Re: [Qemu-devel] [PULL 08/11] linux-user: Check for cpu_init() errors

2015-02-25 Thread Peter Maydell
On 26 February 2015 at 04:58, Eduardo Habkost wrote: > This was the only caller of cpu_init() that was not checking for NULL > yet. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Eduardo Habkost > --- > linux-user/main.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff

[Qemu-devel] [PULL 08/11] linux-user: Check for cpu_init() errors

2015-02-25 Thread Eduardo Habkost
This was the only caller of cpu_init() that was not checking for NULL yet. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- linux-user/main.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index d92702a..111c1ff 100