On 24/08/2018 17:04, Peter Maydell wrote:
> because these values aren't contiguous:
>
> #define ES1370_REG_DAC1_FRAMEADR0xc30
> #define ES1370_REG_DAC2_FRAMEADR0xc38
> #define ES1370_REG_ADC_FRAMEADR 0xd30
>
> so you can't calculate the value of 'd' from the addr
> this way.
>
> (Sim
On 24 August 2018 at 16:04, Peter Maydell wrote:
> On 21 August 2018 at 18:01, Paolo Bonzini wrote:
>> Use the automatic subregister extraction from the memory API, and avoid
>> that Coverity complains about missing fallthrough comments.
>
> Hi -- Coverity (CID 1395167) points out that these chan
On 21 August 2018 at 18:01, Paolo Bonzini wrote:
> Use the automatic subregister extraction from the memory API, and avoid
> that Coverity complains about missing fallthrough comments.
Hi -- Coverity (CID 1395167) points out that these changes are wrong:
> @@ -572,21 +497,19 @@ static void es137
Use the automatic subregister extraction from the memory API, and avoid
that Coverity complains about missing fallthrough comments.
Signed-off-by: Paolo Bonzini
---
hw/audio/es1370.c | 235 ++
1 file changed, 25 insertions(+), 210 deletions(-)
