Re: [Qemu-devel] [PULL 03/48] qemu-timer: introduce timer attributes

2018-11-08 Thread Peter Maydell
On 7 November 2018 at 20:21, Eric Blake wrote: > On 11/6/18 3:45 AM, Paolo Bonzini wrote: >> >> On 06/11/2018 00:16, Eric Blake wrote: >>> >>> On 10/18/18 3:31 PM, Paolo Bonzini wrote: From: Artem Pisarenko Attributes are simple flags, associated with individual timers for the

Re: [Qemu-devel] [PULL 03/48] qemu-timer: introduce timer attributes

2018-11-07 Thread Eric Blake
On 11/6/18 3:45 AM, Paolo Bonzini wrote: On 06/11/2018 00:16, Eric Blake wrote: On 10/18/18 3:31 PM, Paolo Bonzini wrote: From: Artem Pisarenko Attributes are simple flags, associated with individual timers for their whole lifetime.  They intended to be used to mark individual timers for spec

Re: [Qemu-devel] [PULL 03/48] qemu-timer: introduce timer attributes

2018-11-06 Thread Paolo Bonzini
On 06/11/2018 00:16, Eric Blake wrote: > On 10/18/18 3:31 PM, Paolo Bonzini wrote: >> From: Artem Pisarenko >> >> Attributes are simple flags, associated with individual timers for their >> whole lifetime.  They intended to be used to mark individual timers for >> special handling when they fire.

Re: [Qemu-devel] [PULL 03/48] qemu-timer: introduce timer attributes

2018-11-05 Thread Artem Pisarenko
> hw/core/ptimer.o: In function `timer_new_tl': > /home/eblake/qemu/include/qemu/timer.h:536: undefined reference to > `timer_init_tl' > collect2: error: ld returned 1 exit status > make: *** [/home/eblake/qemu/rules.mak:124: tests/ptimer-test] Error 1 > make: *** Waiting for unfinished jobs I

Re: [Qemu-devel] [PULL 03/48] qemu-timer: introduce timer attributes

2018-11-05 Thread Eric Blake
On 10/18/18 3:31 PM, Paolo Bonzini wrote: From: Artem Pisarenko Attributes are simple flags, associated with individual timers for their whole lifetime. They intended to be used to mark individual timers for special handling when they fire. New/init functions family in timer interface updated

[Qemu-devel] [PULL 03/48] qemu-timer: introduce timer attributes

2018-10-18 Thread Paolo Bonzini
From: Artem Pisarenko Attributes are simple flags, associated with individual timers for their whole lifetime. They intended to be used to mark individual timers for special handling when they fire. New/init functions family in timer interface updated and refactored (new 'attribute' argument ad