Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Mike Day
On Wed, May 14, 2014 at 9:43 AM, Jeff Cody wrote: > Prior to a recent commit, this function did not make distinction on > duplicates. As of commit e855e4fb7, duplicates are not longer printed > in the help message: > > e855e4fb7: Ignore duplicate or NULL format_name in bdrv_iterate_format): > Th

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Jeff Cody
On Wed, May 14, 2014 at 09:40:00PM +0800, Fam Zheng wrote: > On Wed, 05/14 09:27, Mike Day wrote: > > On Wed, May 14, 2014 at 8:35 AM, Stefan Hajnoczi wrote: > > > Jeff Cody recently wanted to eliminate duplicate entries in the list. I > > > thought part of your intention was to address the dupli

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Jeff Cody
On Wed, May 14, 2014 at 09:27:31AM -0400, Mike Day wrote: > On Wed, May 14, 2014 at 8:35 AM, Stefan Hajnoczi wrote: > > Jeff Cody recently wanted to eliminate duplicate entries in the list. I > > thought part of your intention was to address the duplicates with your > > patch. > > > > We can back

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Fam Zheng
On Wed, 05/14 09:27, Mike Day wrote: > On Wed, May 14, 2014 at 8:35 AM, Stefan Hajnoczi wrote: > > Jeff Cody recently wanted to eliminate duplicate entries in the list. I > > thought part of your intention was to address the duplicates with your > > patch. > > > > We can back out the sequence API

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Mike Day
On Wed, May 14, 2014 at 8:35 AM, Stefan Hajnoczi wrote: > Jeff Cody recently wanted to eliminate duplicate entries in the list. I > thought part of your intention was to address the duplicates with your > patch. > > We can back out the sequence API if it's not supported on older glib but > it wou

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Stefan Hajnoczi
On Tue, May 13, 2014 at 11:40:47AM -0400, Mike Day wrote: > On Tue, May 13, 2014 at 10:18 AM, Cornelia Huck > wrote: > > > > qemu-img.o: In function `add_format_to_seq': > > /home/cohuck/git/qemu/qemu-img.c:73: undefined reference to > > `g_sequence_lookup' > > collect2: ld returned 1 exit status

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-13 Thread Mike Day
On Tue, May 13, 2014 at 10:18 AM, Cornelia Huck wrote: > > qemu-img.o: In function `add_format_to_seq': > /home/cohuck/git/qemu/qemu-img.c:73: undefined reference to > `g_sequence_lookup' > collect2: ld returned 1 exit status > > g_sequence_lookup has been added with glib 2.28, and this box has >

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-13 Thread Cornelia Huck
On Fri, 9 May 2014 21:03:23 +0200 Stefan Hajnoczi wrote: > From: Mike Day > > The help message for qemu-img lists the supported block formats, of > which there are 27 as of version 2.0.50. The formats are printed in > the order of their driver's position in a linked list, which appears > rando

[Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-09 Thread Stefan Hajnoczi
From: Mike Day The help message for qemu-img lists the supported block formats, of which there are 27 as of version 2.0.50. The formats are printed in the order of their driver's position in a linked list, which appears random. This patch prints the formats in sorted order, making it easier to re