Re: [Qemu-devel] [PULL 00/22] Trivial patches for 2014-05-05

2014-05-07 Thread Michael Tokarev
07.05.2014 22:09, Paolo Bonzini wrote: > Il 07/05/2014 14:50, Peter Maydell ha scritto: >> git bisect says it's this makefile change. >> >> I think the problem here is that the rune for applying obj-specific >> CFLAGS is only in the Rules.make line for %.o: %.c, and not in >> the lines for building

Re: [Qemu-devel] [PULL 00/22] Trivial patches for 2014-05-05

2014-05-07 Thread Paolo Bonzini
Il 07/05/2014 14:50, Peter Maydell ha scritto: git bisect says it's this makefile change. I think the problem here is that the rune for applying obj-specific CFLAGS is only in the Rules.make line for %.o: %.c, and not in the lines for building a .o file from a .cc, .cpp or .m file. That should p

Re: [Qemu-devel] [PULL 00/22] Trivial patches for 2014-05-05

2014-05-07 Thread Peter Maydell
On 7 May 2014 18:05, Michael Tokarev wrote: > Interesting. It looks like I should add C++ compiler to my test environment, > because I really verified the change and it builds here just fine, but it does > not detect C++ so does not try to build C++ files. Yep; we didn't want to require everybod

Re: [Qemu-devel] [PULL 00/22] Trivial patches for 2014-05-05

2014-05-07 Thread Michael Tokarev
07.05.2014 16:50, Peter Maydell wrote: > Hi; I'm afraid this pull breaks the build of the A64 disassembler: > > c++ -I/home/petmay01/linaro/qemu-for-merges/tcg > -I/home/petmay01/linaro/qemu-for-merges/tcg/i386 > -I/home/petmay01/linaro/qemu-for-merges/linux-headers > -I/home/petmay01/linaro/qemu

Re: [Qemu-devel] [PULL 00/22] Trivial patches for 2014-05-05

2014-05-07 Thread Peter Maydell
On 5 May 2014 19:01, Michael Tokarev wrote: > Here's another pull request for trival patches. > This time, it includes: > > - many cleanups from Stefan Weil, mostly adding `static' attrs > - some more trivial patches from glib cleanups, by me and Stefan Hajnoczi > - some more trivial changes fo

[Qemu-devel] [PULL 00/22] Trivial patches for 2014-05-05

2014-05-05 Thread Michael Tokarev
Here's another pull request for trival patches. This time, it includes: - many cleanups from Stefan Weil, mostly adding `static' attrs - some more trivial patches from glib cleanups, by me and Stefan Hajnoczi - some more trivial changes for libcacard, from me and Alon Levy - small fixes from C