On 25/09/2016 02:49, Michael S. Tsirkin wrote:
> > Not quite, there's no reason for the ops to be inside AMDVIState rather
> > than a (static) global.
>
> I guess but it's a logic refactoring, not merely a style one.
> I feel we can do it on top, tool shouldn't require this.
We can do it on top
On Sat, Sep 24, 2016 at 06:10:37PM +0200, Paolo Bonzini wrote:
>
>
> On 24/09/2016 00:05, Michael S. Tsirkin wrote:
> >> e events...
> >> > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU...
> >> > ERROR: struct MemoryRegionIOMMUOps should normally be const
> >> > #1527: FILE: hw/i386/amd_iomm
On 24/09/2016 00:05, Michael S. Tsirkin wrote:
>> e events...
>> > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU...
>> > ERROR: struct MemoryRegionIOMMUOps should normally be const
>> > #1527: FILE: hw/i386/amd_iommu.h:280:
>> > +MemoryRegionIOMMUOps iommu_ops;
>
> False positive.
Not
locally.
>
> Type: series
> Message-id: 1474658051-18617-1-git-send-email-...@redhat.com
> Subject: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> set -e
> git submodule update --init dtc
> make J=8 docker-test-q
@redhat.com
> Subject: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
>
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
>
> # Useful git options
> git config --local diff.renameli
Hi,
Your series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 1474658051-18617-1-git-send-email-...@redhat.com
Subject: [Qemu-devel] [PULL 00/19] virtio, pc
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1474658051-18617-1-git-send-email-...@redhat.com
Subject: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total
The following changes since commit eaff9c4367ac3f7ac44f6c6f4cb7bcd4daa89af5:
Merge remote-tracking branch 'remotes/lalrae/tags/mips-20160923' into staging
(2016-09-23 15:28:07 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
