Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-27 Thread Eric Blake
On 10/25/2017 02:30 PM, Richard Henderson wrote: > Support for Capstone, plus an arm32 fix. > > > Capstone disassembler > > > Richard Henderson (11): > target/i

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-26 Thread Peter Maydell
On 26 October 2017 at 11:06, Daniel P. Berrange wrote: > Do we really expect make/configure todo the right thing when going > backwards in time ? I've always assumed that if you go back in time > when you need to do a 'git clean -f -x d' and re-run configure from > scratch. Certainly in the past

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-26 Thread Daniel P. Berrange
On Thu, Oct 26, 2017 at 10:29:59AM -0300, Philippe Mathieu-Daudé wrote: > On 10/26/2017 07:06 AM, Daniel P. Berrange wrote: > > Do we really expect make/configure todo the right thing when going > > backwards in time ? > > "Yes"? Ideally at least :) What we could do is get scripts/git-submodule.s

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-26 Thread Philippe Mathieu-Daudé
On 10/26/2017 07:06 AM, Daniel P. Berrange wrote: > Do we really expect make/configure todo the right thing when going > backwards in time ? "Yes"? Ideally at least :) > I've always assumed that if you go back in time > when you need to do a 'git clean -f -x d' and re-run configure from> scratch.

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-26 Thread Daniel P. Berrange
On Thu, Oct 26, 2017 at 08:21:48AM +0100, Peter Maydell wrote: > On 26 October 2017 at 08:06, Daniel P. Berrange wrote: > > I'm not sure what's giving you the 'pathspec' message though ? I would > > expect anything to ignore the capstone dir - its just like any other > > untracked file once you go

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-26 Thread Richard Henderson
On 10/26/2017 09:21 AM, Peter Maydell wrote: > On 26 October 2017 at 08:06, Daniel P. Berrange wrote: >> I'm not sure what's giving you the 'pathspec' message though ? I would >> expect anything to ignore the capstone dir - its just like any other >> untracked file once you go back in time before

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-26 Thread Peter Maydell
On 26 October 2017 at 08:06, Daniel P. Berrange wrote: > I'm not sure what's giving you the 'pathspec' message though ? I would > expect anything to ignore the capstone dir - its just like any other > untracked file once you go back in time before it was committed. Sorry, just realized that was t

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-26 Thread Richard Henderson
On 10/26/2017 08:07 AM, Peter Maydell wrote: > On 25 October 2017 at 13:30, Richard Henderson > wrote: >> Support for Capstone, plus an arm32 fix. >> >> >> r~ >> >> >> The following changes since commit 3d7196d43bfe12efe98568cb60057e273652b99b: >> >> Merge remote-tracking branch >> 'remotes/kra

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-26 Thread Daniel P. Berrange
On Thu, Oct 26, 2017 at 07:16:45AM +0100, Peter Maydell wrote: > On 26 October 2017 at 07:07, Peter Maydell wrote: > > Hi. This failed to build for Windows: > > Also, after it failed and I backed out the merge, the next thing I > tried to build failed everywhere with: > > warning: unable to rmdi

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-25 Thread Peter Maydell
On 26 October 2017 at 07:07, Peter Maydell wrote: > Hi. This failed to build for Windows: Also, after it failed and I backed out the merge, the next thing I tried to build failed everywhere with: warning: unable to rmdir capstone: Directory not empty error: pathspec 'capstone' did not match any

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-25 Thread Peter Maydell
On 25 October 2017 at 13:30, Richard Henderson wrote: > Support for Capstone, plus an arm32 fix. > > > r~ > > > The following changes since commit 3d7196d43bfe12efe98568cb60057e273652b99b: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20171023-pull-request' into staging (2017-10-2

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-25 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/11] Disassembler patches Type: series Message-id: 20171025123056.3165-1-richard.hender...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-25 Thread Richard Henderson
Support for Capstone, plus an arm32 fix. r~ The following changes since commit 3d7196d43bfe12efe98568cb60057e273652b99b: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20171023-pull-request' into staging (2017-10-24 16:05:57 +0100) are available in the git repository at: git://gi