Re: [Qemu-devel] [PULL] Standard SD host controller model

2012-07-04 Thread Peter Crosthwaite
On Fri, 2012-06-29 at 11:59 +0100, Peter Maydell wrote: > On 26 June 2012 06:13, Peter A. G. Crosthwaite > wrote: > > target-ppc: Fix 2nd parameter for tcg_gen_shri_tl (2012-06-24 22:52:11 > > +0200) > > > > are available in the git repository at: > > git://developer.petalogix.com/public/qemu.g

Re: [Qemu-devel] [PULL] Standard SD host controller model

2012-06-29 Thread Peter Crosthwaite
Hi Igor, Are you able to make these changes you have negotiated with PMM? If you send me an interdiff that fine, or an incremental patch thats fine - I can remake the series with your changes rolled in. Regards, Peter On Sat, Jun 30, 2012 at 1:22 AM, Igor Mitsyanko wrote: > On 06/29/2012 07:01

Re: [Qemu-devel] [PULL] Standard SD host controller model

2012-06-29 Thread Igor Mitsyanko
On 06/29/2012 07:01 PM, Peter Maydell wrote: On 29 June 2012 15:52, Igor Mitsyanko wrote: On 06/29/2012 02:59 PM, Peter Maydell wrote: The irq code looks dubious: we seem to have a single output irq, but the code does things like: qemu_set_irq(sdhci->irq, sdhci->errintsigen & sdhci->errin

Re: [Qemu-devel] [PULL] Standard SD host controller model

2012-06-29 Thread Peter Maydell
On 29 June 2012 15:52, Igor Mitsyanko wrote: > On 06/29/2012 02:59 PM, Peter Maydell wrote: >> The irq code looks dubious: we seem to have a single output >> irq, but the code does things like: >>     qemu_set_irq(sdhci->irq, sdhci->errintsigen & sdhci->errintsts); >> but in other code paths: >>  

Re: [Qemu-devel] [PULL] Standard SD host controller model

2012-06-29 Thread Igor Mitsyanko
On 06/29/2012 02:59 PM, Peter Maydell wrote: On 26 June 2012 06:13, Peter A. G. Crosthwaite wrote: target-ppc: Fix 2nd parameter for tcg_gen_shri_tl (2012-06-24 22:52:11 +0200) are available in the git repository at: git://developer.petalogix.com/public/qemu.git third-party/igor-sdhci.next

Re: [Qemu-devel] [PULL] Standard SD host controller model

2012-06-29 Thread Peter Maydell
On 26 June 2012 06:13, Peter A. G. Crosthwaite wrote: >  target-ppc: Fix 2nd parameter for tcg_gen_shri_tl (2012-06-24 22:52:11 +0200) > > are available in the git repository at: >  git://developer.petalogix.com/public/qemu.git third-party/igor-sdhci.next Sorry I haven't got round to reviewing th

[Qemu-devel] [PULL] Standard SD host controller model

2012-06-25 Thread Peter A. G. Crosthwaite
target-ppc: Fix 2nd parameter for tcg_gen_shri_tl (2012-06-24 22:52:11 +0200) are available in the git repository at: git://developer.petalogix.com/public/qemu.git third-party/igor-sdhci.next Igor Mitsyanko (2): hw: introduce standard SD host controller exynos4210: Added SD host c