+-- On Thu, 31 Dec 2015, Jason Wang wrote --+
| Btw, looking at ne2000_mem_writew(), it has:
| addr &= ~1;
Yes, this seems to ensure that write starts at an even address.
| at the beginning, so looks like we are really safe, Need only to care
| about writel?
Right, I've sent an updated patc
On 12/31/2015 01:56 PM, P J P wrote:
> +-- On Thu, 31 Dec 2015, Jason Wang wrote --+
> | > -(addr >= NE2000_PMEM_START && addr < NE2000_MEM_SIZE)) {
> | > +if (addr < 32 || (addr >= NE2000_PMEM_START && addr <
> NE2000_MEM_SIZE)) {
> |
> | The change is unnecessary.
>
> Okay.
>
+-- On Thu, 31 Dec 2015, Jason Wang wrote --+
| > -(addr >= NE2000_PMEM_START && addr < NE2000_MEM_SIZE)) {
| > +if (addr < 32 || (addr >= NE2000_PMEM_START && addr <
NE2000_MEM_SIZE)) {
|
| The change is unnecessary.
Okay.
| > +if (addr < 32
| > +|| (addr >= NE2000_P
On 12/31/2015 12:53 PM, P J P wrote:
> From: Prasad J Pandit
>
> While doing ioport r/w operations, ne2000 device emulation suffers
> from OOB r/w errors. Update respective array bounds check to avoid
> OOB access.
>
> Reported-by: Ling Liu
> Signed-off-by: Prasad J Pandit
> ---
> hw/net/ne20
From: Prasad J Pandit
While doing ioport r/w operations, ne2000 device emulation suffers
from OOB r/w errors. Update respective array bounds check to avoid
OOB access.
Reported-by: Ling Liu
Signed-off-by: Prasad J Pandit
---
hw/net/ne2000.c | 28 +++-
1 file changed, 1
