Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-10 Thread Peter Lieven
Am 10.01.2014 19:24, schrieb Paolo Bonzini: > Il 10/01/2014 19:07, Peter Lieven ha scritto: >> >> >> Von meinem iPad gesendet >> >> Am 10.01.2014 um 19:05 schrieb "Paolo Bonzini" : >> >>> Il 10/01/2014 18:16, ronnie sahlberg ha scritto: There is a common exception though, for the case where yo

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-10 Thread Paolo Bonzini
Il 10/01/2014 19:07, Peter Lieven ha scritto: > > > > Von meinem iPad gesendet > > Am 10.01.2014 um 19:05 schrieb "Paolo Bonzini" : > >> Il 10/01/2014 18:16, ronnie sahlberg ha scritto: >>> >>> There is a common exception though, for the case where you read past >>> the end of file. >>> So sho

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-10 Thread Peter Lieven
Von meinem iPad gesendet Am 10.01.2014 um 19:05 schrieb "Paolo Bonzini" : > Il 10/01/2014 18:16, ronnie sahlberg ha scritto: >> >> There is a common exception though, for the case where you read past >> the end of file. >> So short reads should normally not happen. Unless QEMU or the guest >>

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-10 Thread Paolo Bonzini
Il 10/01/2014 18:16, ronnie sahlberg ha scritto: > > There is a common exception though, for the case where you read past > the end of file. > So short reads should normally not happen. Unless QEMU or the guest > sends a request to libnfs to read past the end of the file. Yes, this can happen in

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-10 Thread ronnie sahlberg
On Fri, Jan 10, 2014 at 8:10 AM, Peter Lieven wrote: > > Ronnie, can you also give a short advise on Kevin's question about short > reads. > I think they can happen if we read beyond past EOF or not? > Short reads should normally not happen in libnfs itself since servers are often careful always

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-10 Thread Peter Lieven
Am 10.01.2014 16:46, schrieb Kevin Wolf: > Am 10.01.2014 um 16:05 hat Peter Lieven geschrieben: >> On 10.01.2014 15:49, ronnie sahlberg wrote: >>> On Fri, Jan 10, 2014 at 4:30 AM, Paolo Bonzini wrote: Il 10/01/2014 13:12, Peter Lieven ha scritto: > Then I shall convert everything to a qap

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-10 Thread Kevin Wolf
Am 10.01.2014 um 16:05 hat Peter Lieven geschrieben: > On 10.01.2014 15:49, ronnie sahlberg wrote: > >On Fri, Jan 10, 2014 at 4:30 AM, Paolo Bonzini wrote: > >>Il 10/01/2014 13:12, Peter Lieven ha scritto: > >>>Then I shall convert everything to a qapi schema whereby the current > >>>design of lib

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-10 Thread Peter Lieven
On 10.01.2014 15:49, ronnie sahlberg wrote: On Fri, Jan 10, 2014 at 4:30 AM, Paolo Bonzini wrote: Il 10/01/2014 13:12, Peter Lieven ha scritto: Then I shall convert everything to a qapi schema whereby the current design of libnfs is designed to work with plain URLs. No, no one is asking you t

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-10 Thread ronnie sahlberg
On Fri, Jan 10, 2014 at 4:30 AM, Paolo Bonzini wrote: > Il 10/01/2014 13:12, Peter Lieven ha scritto: >> Then I shall convert everything to a qapi schema whereby the current >> design of libnfs is designed to work with plain URLs. > > No, no one is asking you to do this. URLs are fine, but I agre

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-10 Thread Paolo Bonzini
Il 10/01/2014 13:12, Peter Lieven ha scritto: > Then I shall convert everything to a qapi schema whereby the current > design of libnfs is designed to work with plain URLs. No, no one is asking you to do this. URLs are fine, but I agree with Kevin that parsing them in QEMU is better. Also becaus

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-10 Thread Peter Lieven
On 10.01.2014 12:40, Kevin Wolf wrote: Am 09.01.2014 um 17:08 hat Peter Lieven geschrieben: Am 09.01.2014 15:13, schrieb Kevin Wolf: Am 26.12.2013 um 13:48 hat Peter Lieven geschrieben: v4->v5: - disussed with Ronnie and decided to move URL + Paramter parsing to LibNFS. This allows for U

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-10 Thread Kevin Wolf
Am 09.01.2014 um 17:08 hat Peter Lieven geschrieben: > Am 09.01.2014 15:13, schrieb Kevin Wolf: > > Am 26.12.2013 um 13:48 hat Peter Lieven geschrieben: > >> v4->v5: > >> - disussed with Ronnie and decided to move URL + Paramter parsing to > >> LibNFS. > >>This allows for URL parameter proces

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-09 Thread Peter Lieven
Am 09.01.2014 15:13, schrieb Kevin Wolf: > Am 26.12.2013 um 13:48 hat Peter Lieven geschrieben: >> This patch adds native support for accessing images on NFS shares without >> the requirement to actually mount the entire NFS share on the host. >> >> NFS Images can simply be specified by an url of t

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-09 Thread Kevin Wolf
Am 26.12.2013 um 13:48 hat Peter Lieven geschrieben: > This patch adds native support for accessing images on NFS shares without > the requirement to actually mount the entire NFS share on the host. > > NFS Images can simply be specified by an url of the form: > nfs: > > For example: > qemu-i

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-05 Thread Peter Lieven
On 06.01.2014 02:18, Stefan Hajnoczi wrote: On Fri, Jan 03, 2014 at 12:28:31PM +0100, Peter Lieven wrote: On 03.01.2014 11:37, Stefan Hajnoczi wrote: Looks good. In order to merge this new block driver qemu-iotests support for nfs is required. That way the block driver can be exercised and ch

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-05 Thread Stefan Hajnoczi
On Fri, Jan 03, 2014 at 12:28:31PM +0100, Peter Lieven wrote: > On 03.01.2014 11:37, Stefan Hajnoczi wrote: > >Looks good. In order to merge this new block driver qemu-iotests > >support for nfs is required. That way the block driver can be exercised > >and checked for regressions (I guess you pe

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-03 Thread Peter Lieven
On 03.01.2014 11:37, Stefan Hajnoczi wrote: Looks good. In order to merge this new block driver qemu-iotests support for nfs is required. That way the block driver can be exercised and checked for regressions (I guess you performed manual testing during development). Please see tests/qemu-iote

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-03 Thread Peter Lieven
On 03.01.2014 11:37, Stefan Hajnoczi wrote: Looks good. In order to merge this new block driver qemu-iotests support for nfs is required. That way the block driver can be exercised and checked for regressions (I guess you performed manual testing during development). Please see tests/qemu-iote

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-03 Thread Peter Lieven
On 03.01.2014 11:37, Stefan Hajnoczi wrote: Looks good. In order to merge this new block driver qemu-iotests support for nfs is required. That way the block driver can be exercised and checked for regressions (I guess you performed manual testing during development). Please see tests/qemu-iote

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-03 Thread Stefan Hajnoczi
Looks good. In order to merge this new block driver qemu-iotests support for nfs is required. That way the block driver can be exercised and checked for regressions (I guess you performed manual testing during development). Please see tests/qemu-iotests/common for examples of NBD/SSH/Sheepdog/et

[Qemu-devel] [PATCHv5] block: add native support for NFS

2013-12-26 Thread Peter Lieven
This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS share on the host. NFS Images can simply be specified by an url of the form: nfs: For example: qemu-img create -f qcow2 nfs://10.0.0.1/qemu-images/test.qcow2 You need Li