Re: [Qemu-devel] [PATCHv4 07/11] qxl: make qxl_guest_bug take variable arguments

2011-07-14 Thread Alon Levy
On Thu, Jul 14, 2011 at 10:43:42AM +0200, Gerd Hoffmann wrote: > Hi, > > >-qxl_guest_bug(d, "QXL_IO_MEMSLOT_ADD: val out of range"); > >+qxl_guest_bug(d, "QXL_IO_MEMSLOT_ADD: val out of range\n"); > > Why this change? I'd prefer qxl_guest_bug adding the newline. Just t

Re: [Qemu-devel] [PATCHv4 07/11] qxl: make qxl_guest_bug take variable arguments

2011-07-14 Thread Gerd Hoffmann
Hi, -qxl_guest_bug(d, "QXL_IO_MEMSLOT_ADD: val out of range"); +qxl_guest_bug(d, "QXL_IO_MEMSLOT_ADD: val out of range\n"); Why this change? I'd prefer qxl_guest_bug adding the newline. cheers, Gerd

[Qemu-devel] [PATCHv4 07/11] qxl: make qxl_guest_bug take variable arguments

2011-07-13 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 19 --- hw/qxl.h |2 +- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 3d1f108..34a5f78 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -124,11 +124,15 @@ static void qxl_reset_memslots(PCIQXLDevice *