Re: [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups

2017-10-30 Thread Philippe Mathieu-Daudé
On Mon, Oct 30, 2017 at 4:00 PM, Mark Cave-Ayland wrote: > On 27/10/17 17:42, Philippe Mathieu-Daudé wrote: [...] >> If you don't accept my comments (or don't have time) about keeping >> "hw/sparc/sparc32_dma.h" generic and moving network/scsi parts in >> "hw/sparc/sun4m.h" you can still add to yo

Re: [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups

2017-10-30 Thread Mark Cave-Ayland
On 27/10/17 17:42, Philippe Mathieu-Daudé wrote: > Hi Mark, > > On 10/25/2017 12:59 PM, Mark Cave-Ayland wrote: >> This patchset aims to tidy-up the sparc32_dma code by improving the >> modelling of the espdma/ledma devices using both QOM and the memory >> API which didn't exist when the code was

Re: [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups

2017-10-27 Thread Philippe Mathieu-Daudé
Hi Mark, On 10/25/2017 12:59 PM, Mark Cave-Ayland wrote: > This patchset aims to tidy-up the sparc32_dma code by improving the > modelling of the espdma/ledma devices using both QOM and the memory > API which didn't exist when the code was first written. > > The result is that it is now possible

Re: [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups

2017-10-25 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups Type: series Message-id: 1508947167-5304-1-git-send-email-mark.cave-ayl...@ilande.co.uk === TEST SCRIPT BEGIN === #!/bin/bash BASE

Re: [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups

2017-10-25 Thread Artyom Tarasenko
On Wed, Oct 25, 2017 at 5:59 PM, Mark Cave-Ayland wrote: > This patchset aims to tidy-up the sparc32_dma code by improving the > modelling of the espdma/ledma devices using both QOM and the memory > API which didn't exist when the code was first written. > > The result is that it is now possible t

[Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups

2017-10-25 Thread Mark Cave-Ayland
This patchset aims to tidy-up the sparc32_dma code by improving the modelling of the espdma/ledma devices using both QOM and the memory API which didn't exist when the code was first written. The result is that it is now possible to remove both the iommu_opaque and is_ledma workarounds from the co