Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
Hi, Hmm. Alon, is it an option to just leave the whole qxl-render stuff in sync mode for now and convert it later? Or will that have bad interactions with QXL_IO_UPDATE_AREA_ASYNC being used by the guest? It's not a problem. I do have a working version using async monitor command, but I wi

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 03:45:16PM +0200, Gerd Hoffmann wrote: > On 07/13/11 14:32, Luiz Capitulino wrote: > >>Not sure. Luiz, do we have async monitor commands meanwhile? > > > >Not yet, this is a QAPI feature that should land soon, but it's not > >available yet. > > Hmm. Alon, is it an option

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
On 07/13/11 14:32, Luiz Capitulino wrote: Not sure. Luiz, do we have async monitor commands meanwhile? Not yet, this is a QAPI feature that should land soon, but it's not available yet. Hmm. Alon, is it an option to just leave the whole qxl-render stuff in sync mode for now and convert it

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 15:56:55 +0300 Alon Levy wrote: > On Wed, Jul 13, 2011 at 09:33:26AM -0300, Luiz Capitulino wrote: > > On Wed, 13 Jul 2011 14:29:16 +0300 > > Alon Levy wrote: > > > > > On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: > > > > On 07/13/11 11:29, Alon Levy wrote:

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 09:33:26AM -0300, Luiz Capitulino wrote: > On Wed, 13 Jul 2011 14:29:16 +0300 > Alon Levy wrote: > > > On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: > > > On 07/13/11 11:29, Alon Levy wrote: > > > >On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wr

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 14:29:16 +0300 Alon Levy wrote: > On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: > > On 07/13/11 11:29, Alon Levy wrote: > > >On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > > >>On 07/12/11 15:55, Alon Levy wrote: > > >>>Later the save will hap

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 13:46:50 +0200 Gerd Hoffmann wrote: >Hi, > > > I'd rather try the MONITOR_CMD_ASYNC thing then the cond variable, it's > > becoming pretty > > ugly. Also I guess what Daniel described is possible, but it changes the > > usage of screendump > > even more. Is turning do_s

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 12:41:48 +0200 Gerd Hoffmann wrote: > On 07/13/11 11:29, Alon Levy wrote: > > On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > >> On 07/12/11 15:55, Alon Levy wrote: > >>> Later the save will happen asynchronously on surface_updated callback. > >> > >> Hmm. I

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
Hi, I'd rather try the MONITOR_CMD_ASYNC thing then the cond variable, it's becoming pretty ugly. Also I guess what Daniel described is possible, but it changes the usage of screendump even more. Is turning do_screen_dump to async viable? I think I'll work on it. Daniel's suggestion is a n

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: > On 07/13/11 11:29, Alon Levy wrote: > >On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > >>On 07/12/11 15:55, Alon Levy wrote: > >>>Later the save will happen asynchronously on surface_updated callback. > >> > >>Hmm. I

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Daniel P. Berrange
On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > On 07/12/11 15:55, Alon Levy wrote: > >Later the save will happen asynchronously on surface_updated callback. > > Hmm. I can see why you are doing that. It makes the file being > written *after* the monitor command finishes though,

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Daniel P. Berrange
On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: > On 07/13/11 11:29, Alon Levy wrote: > >On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > >>On 07/12/11 15:55, Alon Levy wrote: > >>>Later the save will happen asynchronously on surface_updated callback. > >> > >>Hmm. I

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
On 07/13/11 11:29, Alon Levy wrote: On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: Later the save will happen asynchronously on surface_updated callback. Hmm. I can see why you are doing that. It makes the file being written *after* the mo

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > On 07/12/11 15:55, Alon Levy wrote: > >Later the save will happen asynchronously on surface_updated callback. > > Hmm. I can see why you are doing that. It makes the file being > written *after* the monitor command finishes though,

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
On 07/12/11 15:55, Alon Levy wrote: Later the save will happen asynchronously on surface_updated callback. Hmm. I can see why you are doing that. It makes the file being written *after* the monitor command finishes though, which I think we should avoid. cheers, Gerd

[Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-12 Thread Alon Levy
Later the save will happen asynchronously on surface_updated callback. --- hw/qxl-render.c | 10 ++ hw/qxl.c|2 +- hw/qxl.h|2 ++ 3 files changed, 13 insertions(+), 1 deletions(-) diff --git a/hw/qxl-render.c b/hw/qxl-render.c index 60b822d..e64b646 100644 --- a/