[Qemu-devel] [PATCHv3] qxl: add io_port_to_string

2011-07-12 Thread Alon Levy
--- hw/qxl.c | 62 +- 1 files changed, 61 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6862bc8..7be7ae1 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -407,6 +407,65 @@ static const char *qxl_mode_to_string(int mode)

Re: [Qemu-devel] [PATCHv3] qxl: add io_port_to_string

2011-06-29 Thread Alon Levy
On Wed, Jun 29, 2011 at 03:03:32PM +0200, Gerd Hoffmann wrote: > Hi, > > >-dprint(d, 1, "%s: unexpected port 0x%x in vga mode\n", > >__FUNCTION__, io_port); > >+dprint(d, 1, "%s: unexpected port 0x%x (%s) in vga mode\n", > >+__FUNCTION__, io_port, io_port_to_string(i

Re: [Qemu-devel] [PATCHv3] qxl: add io_port_to_string

2011-06-29 Thread Gerd Hoffmann
Hi, -dprint(d, 1, "%s: unexpected port 0x%x in vga mode\n", __FUNCTION__, io_port); +dprint(d, 1, "%s: unexpected port 0x%x (%s) in vga mode\n", +__FUNCTION__, io_port, io_port_to_string(io_port)); Is this worth it? Should be a quite rare event ... cheers, Ge

[Qemu-devel] [PATCHv3] qxl: add io_port_to_string

2011-06-29 Thread Alon Levy
--- hw/qxl.c | 64 +- 1 files changed, 63 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 22455af..0ab8074 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -433,6 +433,67 @@ static const char *qxl_mode_to_string(int mode)