Re: [Qemu-devel] [PATCHv3] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 11:39:21AM -0600, Anthony Liguori wrote: > Markus Armbruster writes: > > > "Michael S. Tsirkin" writes: > > > >> libvirt has a long-standing bug: when removing the device, > >> it can request removal but does not know when the > >> removal completes. Add an event so we ca

Re: [Qemu-devel] [PATCHv3] qdev: DEVICE_DELETED event

2013-03-07 Thread Anthony Liguori
Markus Armbruster writes: > "Michael S. Tsirkin" writes: > >> libvirt has a long-standing bug: when removing the device, >> it can request removal but does not know when the >> removal completes. Add an event so we can fix this in a robust way. > > This is *v4*. I think you should respin to avo

Re: [Qemu-devel] [PATCHv3] qdev: DEVICE_DELETED event

2013-03-07 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > libvirt has a long-standing bug: when removing the device, > it can request removal but does not know when the > removal completes. Add an event so we can fix this in a robust way. This is *v4*. I think you should respin to avoid confusing Anthony's tools. Recomm

[Qemu-devel] [PATCHv3] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin --- Changes from v3: - Document that we only emit events for devices with a

Re: [Qemu-devel] [PATCHv3] qdev: DEVICE_DELETED event

2013-03-07 Thread Andreas Färber
Am 07.03.2013 10:49, schrieb Michael S. Tsirkin: > libvirt has a long-standing bug: when removing the device, > it can request removal but does not know when the > removal completes. Add an event so we can fix this in a robust way. > > Signed-off-by: Michael S. Tsirkin > --- > > Changes from v2:

[Qemu-devel] [PATCHv3] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin --- Changes from v2: - move event toward the end of device_unparent, so tha