Re: [Qemu-devel] [PATCHv2 2/2] sun4m: Add Sun CG3 framebuffer initialisation function

2014-02-19 Thread Mark Cave-Ayland
On 17/02/14 12:30, Mark Cave-Ayland wrote: On 09/02/14 15:32, Andreas Färber wrote: IIUC SUNW,cgthree is an optional device, so it's not covered by my qom-test. Please follow-up with a tests/cg3-test.c so that it gets covered. Compare my recent PCI NIC series for how such a stub could look lik

Re: [Qemu-devel] [PATCHv2 2/2] sun4m: Add Sun CG3 framebuffer initialisation function

2014-02-17 Thread Mark Cave-Ayland
On 09/02/14 15:32, Andreas Färber wrote: IIUC SUNW,cgthree is an optional device, so it's not covered by my qom-test. Please follow-up with a tests/cg3-test.c so that it gets covered. Compare my recent PCI NIC series for how such a stub could look like, in particular vmxnet3-test.c since this wi

Re: [Qemu-devel] [PATCHv2 2/2] sun4m: Add Sun CG3 framebuffer initialisation function

2014-02-09 Thread Andreas Färber
Am 08.02.2014 17:38, schrieb Mark Cave-Ayland: > In order to allow the user to choose the framebuffer for sparc-softmmu, add > -vga tcx and -vga cg3 options to the QEMU command line. If no option is > specified, the default TCX framebuffer is used. > > Signed-off-by: Mark Cave-Ayland > CC: Blue S

[Qemu-devel] [PATCHv2 2/2] sun4m: Add Sun CG3 framebuffer initialisation function

2014-02-08 Thread Mark Cave-Ayland
In order to allow the user to choose the framebuffer for sparc-softmmu, add -vga tcx and -vga cg3 options to the QEMU command line. If no option is specified, the default TCX framebuffer is used. Signed-off-by: Mark Cave-Ayland CC: Blue Swirl CC: Anthony Liguori CC: Peter Maydell CC: Bob Breue