Re: [Qemu-devel] [PATCHv2] target-arm/abi32: check for segfault in do_kernel_trap

2017-01-06 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCHv2] target-arm/abi32: check for segfault in do_kernel_trap Message-id: 20170106162116.12859-1-kirkser...@gmail.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCHv2] target-arm/abi32: check for segfault in do_kernel_trap

2017-01-06 Thread Peter Maydell
On 6 January 2017 at 16:21, Seraphime Kirkovski wrote: > Currently, the cmpxchg implementation tests whether the destination address > is readable: > - if it is, we read the value and continue with the comparison > - if isn't, i.e. access to addr would segfault, we assume that src != dest >

[Qemu-devel] [PATCHv2] target-arm/abi32: check for segfault in do_kernel_trap

2017-01-06 Thread Seraphime Kirkovski
Currently, the cmpxchg implementation tests whether the destination address is readable: - if it is, we read the value and continue with the comparison - if isn't, i.e. access to addr would segfault, we assume that src != dest rather than queuing a SIGSEGV. The same problem exists in the c