Re: [Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Hello, Eric Blake, on Thu 24 Mar 2016 15:36:19 -0600, wrote: > What happens if 'net' is provided but 'ip4' is false? Is that a user error? We could do that, yes. > The existing 'InetSocketAddress' QAPI type spells these as 'ipv4' and > ipv6'; should we use the same spelling for consistency? Th

Re: [Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Eric Blake, on Thu 24 Mar 2016 15:36:19 -0600, wrote: > > Make net=none disable IPv4 and ip6-net=none disable IPv6, so the user can > > setup IPv4-only and IPv6-only network environments. > > This mentions 'net=none', but I don't see that in the patch below; > instead I see a new boolean. Eeergl,

Re: [Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

2016-03-24 Thread Eric Blake
On 03/24/2016 03:00 PM, Samuel Thibault wrote: In the subject line: "Allow to" is not idiomatic English. "Allow" requires either a subject ("Allow someone to disable"), or a gerund ("Allow disabling"). > Make net=none disable IPv4 and ip6-net=none disable IPv6, so the user can > setup IPv4-only

[Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Make net=none disable IPv4 and ip6-net=none disable IPv6, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- net/slirp.c | 19 +-- qapi-schema.json | 15 +-- qemu-options.hx | 19 --- slirp/i