Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Peter Maydell
On 11 May 2015 at 16:52, Markus Armbruster wrote: > I agree silently ignoring command line options isn't nice, but it's > unfortunately what QEMU has always done. Actually, we're inconsistent (who'd have guessed? :-)). For instance if CONFIG_CURSES isn't defined then we print an error if you try

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 17:09, Markus Armbruster wrote: > Fails to link if I disable CONFIG_PARALLEL in > default-configs/mips-softmmu.mak: > > LINK mips-softmmu/qemu-system-mips > hw/mips/mips_jazz.o: In function `mips_jazz_init': > /home/armbru/work/qemu/hw/mips/mips_jazz.c:323: undefined

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 17:52, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 11/05/2015 11:36, Miroslav Rezanina wrote: > This patch will make "-parallel" a nop. The right thing to do is to > fail startup whenever -parallel is passed and CONFIG_PARALLEL is disabled. > >>> This was

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/05/2015 11:36, Miroslav Rezanina wrote: >>> > This patch will make "-parallel" a nop. The right thing to do is to >>> > fail startup whenever -parallel is passed and CONFIG_PARALLEL is disabled. >>> > >> This was original behavior before 07dc788. Intention of this

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Markus Armbruster
Miroslav Rezanina writes: > On Mon, May 11, 2015 at 08:46:19AM +0200, Markus Armbruster wrote: >> mreza...@redhat.com writes: >> >> > From: Miroslav Rezanina >> > >> > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored >> > out initialization to parallel_hds_isa_init funct

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Markus Armbruster
mreza...@redhat.com writes: > From: Miroslav Rezanina > > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored > out initialization to parallel_hds_isa_init function in hw/char/parallel.c > that is not build. > > Stub file is added to be able to disable CONFIG_PARALLEL. This

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Miroslav Rezanina
On Mon, May 11, 2015 at 10:40:04AM +0200, Paolo Bonzini wrote: > > > On 11/05/2015 07:38, mreza...@redhat.com wrote: > > From: Miroslav Rezanina > > > > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored > > out initialization to parallel_hds_isa_init function in hw/char/p

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Miroslav Rezanina
On Mon, May 11, 2015 at 08:46:19AM +0200, Markus Armbruster wrote: > mreza...@redhat.com writes: > > > From: Miroslav Rezanina > > > > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored > > out initialization to parallel_hds_isa_init function in hw/char/parallel.c > > that

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 11:36, Miroslav Rezanina wrote: >> > This patch will make "-parallel" a nop. The right thing to do is to >> > fail startup whenever -parallel is passed and CONFIG_PARALLEL is disabled. >> > > This was original behavior before 07dc788. Intention of this patch is to > make qemu buil

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 07:38, mreza...@redhat.com wrote: > From: Miroslav Rezanina > > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored > out initialization to parallel_hds_isa_init function in hw/char/parallel.c > that is not build. > > Stub file is added to be able to disabl

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-10 Thread Markus Armbruster
mreza...@redhat.com writes: > From: Miroslav Rezanina > > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored > out initialization to parallel_hds_isa_init function in hw/char/parallel.c > that is not build. > > Stub file is added to be able to disable CONFIG_PARALLEL. This

[Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-10 Thread mrezanin
From: Miroslav Rezanina Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored out initialization to parallel_hds_isa_init function in hw/char/parallel.c that is not build. Stub file is added to be able to disable CONFIG_PARALLEL. This file is used in targets using parallel_h