Re: [Qemu-devel] [PATCHv2] Reducing stack frame size in stream_process_mem2s()

2016-10-05 Thread Alistair Francis
On Tue, Oct 4, 2016 at 1:56 PM, Edgar E. Iglesias wrote: > On Tue, Oct 04, 2016 at 11:41:42PM +0530, rutu.shah...@gmail.com wrote: >> From: Rutuja Shah >> >> Hi, >> This patch allocates memory for txbuf in struct Stream rather than the stack. >> As a result, the stack frame size is reduced of str

Re: [Qemu-devel] [PATCHv2] Reducing stack frame size in stream_process_mem2s()

2016-10-05 Thread Stefan Hajnoczi
On Tue, Oct 04, 2016 at 11:41:42PM +0530, rutu.shah...@gmail.com wrote: > From: Rutuja Shah > > Hi, > This patch allocates memory for txbuf in struct Stream rather than the stack. > As a result, the stack frame size is reduced of stream_process_mem2s(). > Signed-off-by: Rutuja Shah > --- > hw/d

Re: [Qemu-devel] [PATCHv2] Reducing stack frame size in stream_process_mem2s()

2016-10-04 Thread Edgar E. Iglesias
On Tue, Oct 04, 2016 at 11:41:42PM +0530, rutu.shah...@gmail.com wrote: > From: Rutuja Shah > > Hi, > This patch allocates memory for txbuf in struct Stream rather than the stack. > As a result, the stack frame size is reduced of stream_process_mem2s(). Hi Rutuja, A nit-pick: The commit message

Re: [Qemu-devel] [PATCHv2] Reducing stack frame size in stream_process_mem2s()

2016-10-04 Thread no-reply
stack frame size in stream_process_mem2s() === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 make J=8 docker-test-quick@centos6 make J=8 docker-test-mingw@fedora === TEST SCRIPT END === Updating

[Qemu-devel] [PATCHv2] Reducing stack frame size in stream_process_mem2s()

2016-10-04 Thread rutu . shah . 26
From: Rutuja Shah Hi, This patch allocates memory for txbuf in struct Stream rather than the stack. As a result, the stack frame size is reduced of stream_process_mem2s(). Signed-off-by: Rutuja Shah --- hw/dma/xilinx_axidma.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff -