Re: [Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable

2013-09-03 Thread Gerd Hoffmann
> > This (and some other bits) are pure code motion from vl.c, correct? > > Can you split this into a separate patch please? That'll simplify the > > review o the actual code changes. > > Yes, this is pure code motion. I'll split the code to separate patches. > > > > It also doesn't make much se

Re: [Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable

2013-09-03 Thread Miroslav Rezanina
- Original Message - > From: "Gerd Hoffmann" > To: mreza...@redhat.com > Cc: qemu-devel@nongnu.org > Sent: Tuesday, September 3, 2013 9:41:11 AM > Subject: Re: [Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable > > > diff --git a/hw/bt/core.

Re: [Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable

2013-09-03 Thread Paolo Bonzini
Il 03/09/2013 09:26, mreza...@redhat.com ha scritto: > From: Miroslav Rezanina > > Use usb_legacy_register handling to create bt-dongle device. This allows > to disable usb-bt-dongle device using CONFIG_BLUETOOTH option. > > Signed-off-by: Miroslav Rezanina > --- Looks good to me, just one sma

Re: [Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable

2013-09-03 Thread Gerd Hoffmann
> diff --git a/hw/bt/core.c b/hw/bt/core.c > index 49012e0..ef27b15 100644 > --- a/hw/bt/core.c > +++ b/hw/bt/core.c > @@ -119,3 +119,28 @@ void bt_device_done(struct bt_device_s *dev) > > *p = dev->next; > } > + > +static struct bt_vlan_s { > +struct bt_scatternet_s net; > +int id;

[Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable

2013-09-03 Thread mrezanin
From: Miroslav Rezanina Use usb_legacy_register handling to create bt-dongle device. This allows to disable usb-bt-dongle device using CONFIG_BLUETOOTH option. Signed-off-by: Miroslav Rezanina --- hw/bt/core.c | 25 hw/bt/hci.c| 51 +++