Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread Amit Shah
On (Tue) 16 Dec 2014 [16:38:15], David Gibson wrote: > On Tue, Dec 16, 2014 at 10:08:49AM +0530, Amit Shah wrote: > > On (Tue) 16 Dec 2014 [15:33:54], David Gibson wrote: > > > On Tue, Dec 16, 2014 at 09:43:30AM +0530, Amit Shah wrote: > > > > Can you split this patch so the config change and the

Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread David Gibson
On Tue, Dec 16, 2014 at 10:08:49AM +0530, Amit Shah wrote: > On (Tue) 16 Dec 2014 [15:33:54], David Gibson wrote: > > On Tue, Dec 16, 2014 at 09:43:30AM +0530, Amit Shah wrote: > > > On (Fri) 12 Dec 2014 [16:26:35], David Gibson wrote: > > > > On a bi-endian target, with a guest in the non-default

Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread Amit Shah
On (Tue) 16 Dec 2014 [15:33:54], David Gibson wrote: > On Tue, Dec 16, 2014 at 09:43:30AM +0530, Amit Shah wrote: > > On (Fri) 12 Dec 2014 [16:26:35], David Gibson wrote: > > > On a bi-endian target, with a guest in the non-default endian mode, > > > attempting to migrate twice in a row with a virt

Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread David Gibson
On Tue, Dec 16, 2014 at 09:43:30AM +0530, Amit Shah wrote: > On (Fri) 12 Dec 2014 [16:26:35], David Gibson wrote: > > On a bi-endian target, with a guest in the non-default endian mode, > > attempting to migrate twice in a row with a virtio-serial device wil > > cause a qemu SEGV on the second outg

Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread Amit Shah
On (Fri) 12 Dec 2014 [16:26:35], David Gibson wrote: > On a bi-endian target, with a guest in the non-default endian mode, > attempting to migrate twice in a row with a virtio-serial device wil > cause a qemu SEGV on the second outgoing migration. > > The problem is that virtio_serial_save_device(

Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread David Gibson
On Mon, Dec 15, 2014 at 03:59:56PM +0100, Alexander Graf wrote: > > > On 12.12.14 06:26, David Gibson wrote: > > On a bi-endian target, with a guest in the non-default endian mode, > > attempting to migrate twice in a row with a virtio-serial device wil > > cause a qemu SEGV on the second outgoin

Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread Alexander Graf
On 12.12.14 06:26, David Gibson wrote: > On a bi-endian target, with a guest in the non-default endian mode, > attempting to migrate twice in a row with a virtio-serial device wil > cause a qemu SEGV on the second outgoing migration. > > The problem is that virtio_serial_save_device() (and other

[Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-11 Thread David Gibson
On a bi-endian target, with a guest in the non-default endian mode, attempting to migrate twice in a row with a virtio-serial device wil cause a qemu SEGV on the second outgoing migration. The problem is that virtio_serial_save_device() (and other places) expect VirtIOSerial->config to be in curre