Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-12 Thread Avi Kivity
On 01/11/2010 09:18 PM, Anthony Liguori wrote: On 01/07/2010 10:24 AM, Gleb Natapov wrote: diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 4084503..6a841de 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -17,6 +17,7 @@ #include #include +#include This breaks the build o

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-12 Thread Avi Kivity
On 01/12/2010 09:23 AM, Gleb Natapov wrote: On Mon, Jan 11, 2010 at 01:18:32PM -0600, Anthony Liguori wrote: On 01/07/2010 10:24 AM, Gleb Natapov wrote: diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 4084503..6a841de 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-11 Thread Gleb Natapov
On Mon, Jan 11, 2010 at 01:18:32PM -0600, Anthony Liguori wrote: > On 01/07/2010 10:24 AM, Gleb Natapov wrote: > >diff --git a/target-i386/kvm.c b/target-i386/kvm.c > >index 4084503..6a841de 100644 > >--- a/target-i386/kvm.c > >+++ b/target-i386/kvm.c > >@@ -17,6 +17,7 @@ > > #include > > > > #in

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-11 Thread Jan Kiszka
Anthony Liguori wrote: > On 01/11/2010 02:40 PM, Jan Kiszka wrote: >> Anthony Liguori wrote: >> >>> On 01/07/2010 10:24 AM, Gleb Natapov wrote: >>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 4084503..6a841de 100644 --- a/target-i386/kvm.c +++ b/target-i386/

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-11 Thread Anthony Liguori
On 01/11/2010 02:40 PM, Jan Kiszka wrote: Anthony Liguori wrote: On 01/07/2010 10:24 AM, Gleb Natapov wrote: diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 4084503..6a841de 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -17,6 +17,7 @@ #include #include +#in

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-11 Thread Jan Kiszka
Anthony Liguori wrote: > On 01/07/2010 10:24 AM, Gleb Natapov wrote: >> diff --git a/target-i386/kvm.c b/target-i386/kvm.c >> index 4084503..6a841de 100644 >> --- a/target-i386/kvm.c >> +++ b/target-i386/kvm.c >> @@ -17,6 +17,7 @@ >> #include >> >> #include >> +#include > > This breaks the bui

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-11 Thread Anthony Liguori
On 01/07/2010 10:24 AM, Gleb Natapov wrote: diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 4084503..6a841de 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -17,6 +17,7 @@ #include #include +#include This breaks the build on a default F12 install because while kvm.h is

[Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-07 Thread Gleb Natapov
Initialize KVM paravirt cpuid leaf and allow user to control guest visible PV features through -cpu flag. Signed-off-by: Gleb Natapov --- v1->v2 fix indentation remove unneeded ifdefs diff --git a/target-i386/cpu.h b/target-i386/cpu.h index f3834b3..fbe11b8 100644 --- a/target-i386/cpu.h +++