Re: [Qemu-devel] [PATCHv1 12/14] target/s390x: convert to TranslatorOps

2018-03-02 Thread Cornelia Huck
On Thu, 1 Mar 2018 17:53:56 -0500 "Emilio G. Cota" wrote: > Note: I looked into dropping dc->do_debug. However, I don't see > an easy way to do it given that TOO_MANY is also valid > when we just translate more than max_insns. Thus, the check > for do_debug in "case DISAS_PC_CC_UPDATED" would st

Re: [Qemu-devel] [PATCHv1 12/14] target/s390x: convert to TranslatorOps

2018-03-02 Thread David Hildenbrand
On 01.03.2018 23:53, Emilio G. Cota wrote: > Note: I looked into dropping dc->do_debug. However, I don't see > an easy way to do it given that TOO_MANY is also valid > when we just translate more than max_insns. Thus, the check > for do_debug in "case DISAS_PC_CC_UPDATED" would still need > additio

[Qemu-devel] [PATCHv1 12/14] target/s390x: convert to TranslatorOps

2018-03-01 Thread Emilio G. Cota
Note: I looked into dropping dc->do_debug. However, I don't see an easy way to do it given that TOO_MANY is also valid when we just translate more than max_insns. Thus, the check for do_debug in "case DISAS_PC_CC_UPDATED" would still need additional state to know whether or not we came from breakpo