Re: [Qemu-devel] [PATCH v9 04/31] block: Add BDS.auto_backing_file

2018-06-28 Thread Eric Blake
On 06/27/2018 07:07 PM, Max Reitz wrote: If the backing file is overridden, this most probably does change the guest-visible data of a BDS. Therefore, we will need to consider this in bdrv_refresh_filename(). So all in all, there will be false negatives where (as of a future patch) bdrv_refr

[Qemu-devel] [PATCH v9 04/31] block: Add BDS.auto_backing_file

2018-06-27 Thread Max Reitz
If the backing file is overridden, this most probably does change the guest-visible data of a BDS. Therefore, we will need to consider this in bdrv_refresh_filename(). To see whether it has been overridden, we might want to compare bs->backing_file and bs->backing->bs->filename. However, bs->bac