Re: [Qemu-devel] [PATCH v9 04/13] dirty-bitmap: add locked state

2017-12-27 Thread Fam Zheng
On Wed, 12/20 18:49, Vladimir Sementsov-Ogievskiy wrote: > diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c > index fe27ddfb83..6218740c95 100644 > --- a/block/dirty-bitmap.c > +++ b/block/dirty-bitmap.c > @@ -40,6 +40,8 @@ struct BdrvDirtyBitmap { > QemuMutex *mutex; > HBitmap *b

Re: [Qemu-devel] [PATCH v9 04/13] dirty-bitmap: add locked state

2017-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2017 05:03, John Snow wrote: On 12/20/2017 10:49 AM, Vladimir Sementsov-Ogievskiy wrote: Add special state, when qmp operations on the bitmap are disabled. It is needed during bitmap migration. "Frozen" state is not appropriate here, because it looks like bitmap is unchanged. As of righ

Re: [Qemu-devel] [PATCH v9 04/13] dirty-bitmap: add locked state

2017-12-22 Thread Vladimir Sementsov-Ogievskiy
20.12.2017 18:49, Vladimir Sementsov-Ogievskiy wrote: Add special state, when qmp operations on the bitmap are disabled. It is needed during bitmap migration. "Frozen" state is not appropriate here, because it looks like bitmap is unchanged. Signed-off-by: Vladimir Sementsov-Ogievskiy --- [..

Re: [Qemu-devel] [PATCH v9 04/13] dirty-bitmap: add locked state

2017-12-21 Thread John Snow
On 12/20/2017 10:49 AM, Vladimir Sementsov-Ogievskiy wrote: > Add special state, when qmp operations on the bitmap are disabled. > It is needed during bitmap migration. "Frozen" state is not > appropriate here, because it looks like bitmap is unchanged. > As of right now this breaks test 124, d

[Qemu-devel] [PATCH v9 04/13] dirty-bitmap: add locked state

2017-12-20 Thread Vladimir Sementsov-Ogievskiy
Add special state, when qmp operations on the bitmap are disabled. It is needed during bitmap migration. "Frozen" state is not appropriate here, because it looks like bitmap is unchanged. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 5 - include/block/dirty