On 11/03/2015 09:19 AM, Markus Armbruster wrote:
>>> I'm assuming this patch is based on
>>> [PATCH v8 06/17] qapi-types: Consolidate gen_struct() and gen_union()
>>> which has
>>>
>>> def check(self, schema, members, seen):
>>> if self.tag_name:# flat union
>>> self.ta
Eric Blake writes:
> On 11/03/2015 07:02 AM, Markus Armbruster wrote:
>
I'm afraid you're omitting a few steps here, and I think you missed
QAPISchemaObjectVariants.check()'s self.tag_member.check().
>>>
>>> There is no self.tag_member.check(), any more; rather, my earlier
>>> patches h
On 11/03/2015 07:02 AM, Markus Armbruster wrote:
>>> I'm afraid you're omitting a few steps here, and I think you missed
>>> QAPISchemaObjectVariants.check()'s self.tag_member.check().
>>
>> There is no self.tag_member.check(), any more; rather, my earlier
>> patches have reworked things so that t
Eric Blake writes:
> On 11/03/2015 04:06 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> The implementation of QAPISchemaObjectTypeMember.check() always
>>> adds the member currently being checked to both the all_members
>>> and seen parameters.
>>
>> QAPISchemaObjectTypeMember.check
On 11/03/2015 04:06 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> The implementation of QAPISchemaObjectTypeMember.check() always
>> adds the member currently being checked to both the all_members
>> and seen parameters.
>
> QAPISchemaObjectTypeMember.check() does four things:
>
> 1. C
Eric Blake writes:
> The implementation of QAPISchemaObjectTypeMember.check() always
> adds the member currently being checked to both the all_members
> and seen parameters.
QAPISchemaObjectTypeMember.check() does four things:
1. Compute self.type
Precondition: all types are defined.
2. Ac
The implementation of QAPISchemaObjectTypeMember.check() always
adds the member currently being checked to both the all_members
and seen parameters. However, the three callers of this method
pass in the following parameters:
QAPISchemaObjectType.check():
- all_members contains all non-variant me
