Re: [Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack

2015-07-29 Thread Don Slutz
On 7/5/2015 2:40 AM, Michael S. Tsirkin wrote: On Fri, Jul 03, 2015 at 03:50:19PM +0200, Paolo Bonzini wrote: On 03/07/2015 15:08, Don Slutz wrote: Creating it at the pc level and propagating makes code messy but I'd go along with it if it made sense from user's point of view, but it does not

Re: [Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack

2015-07-04 Thread Michael S. Tsirkin
On Fri, Jul 03, 2015 at 03:50:19PM +0200, Paolo Bonzini wrote: > > > On 03/07/2015 15:08, Don Slutz wrote: > >>> > >> Creating it at the pc level and propagating makes code > >> messy but I'd go along with it if it made sense from > >> user's point of view, but it does not seem to make sense: > >

Re: [Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack

2015-07-04 Thread Paolo Bonzini
On 03/07/2015 15:08, Don Slutz wrote: >>> >> Creating it at the pc level and propagating makes code >> messy but I'd go along with it if it made sense from >> user's point of view, but it does not seem to make sense: >> to me this looks more like a CPU feature than a machine property. >> Or the p

Re: [Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack

2015-07-03 Thread Don Slutz
On 07/01/15 02:50, Michael S. Tsirkin wrote: On Tue, Jun 23, 2015 at 07:39:33PM -0400, Don Slutz wrote: From: Don Slutz This is done by adding a new machine property vmware-port-ring3 that needs to be enabled to have any effect. It only effects accel=tcg mode. It is needed if you want to use

Re: [Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack

2015-06-30 Thread Michael S. Tsirkin
On Tue, Jun 23, 2015 at 07:39:33PM -0400, Don Slutz wrote: > From: Don Slutz > > This is done by adding a new machine property vmware-port-ring3 that > needs to be enabled to have any effect. It only effects accel=tcg > mode. It is needed if you want to use VMware tools in accel=tcg > mode. >

[Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack

2015-06-23 Thread Don Slutz
From: Don Slutz This is done by adding a new machine property vmware-port-ring3 that needs to be enabled to have any effect. It only effects accel=tcg mode. It is needed if you want to use VMware tools in accel=tcg mode. Signed-off-by: Don Slutz CC: Don Slutz --- hw/i386/pc.c |