Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2017 at 05:08:40PM +0100, Laszlo Ersek wrote: > On 02/21/17 15:14, Michael S. Tsirkin wrote: > > On Tue, Feb 21, 2017 at 10:58:05AM +0100, Laszlo Ersek wrote: > >> On 02/21/17 02:43, Michael S. Tsirkin wrote: > >>> On Mon, Feb 20, 2017 at 09:55:40PM +0100, Laszlo Ersek wrote: >

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-21 Thread Laszlo Ersek
On 02/21/17 17:17, Michael S. Tsirkin wrote: > On Tue, Feb 21, 2017 at 05:08:40PM +0100, Laszlo Ersek wrote: >> On 02/21/17 15:14, Michael S. Tsirkin wrote: >>> On Tue, Feb 21, 2017 at 10:58:05AM +0100, Laszlo Ersek wrote: On 02/21/17 02:43, Michael S. Tsirkin wrote: > On Mon, Feb 20, 2017

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-21 Thread Laszlo Ersek
On 02/21/17 15:14, Michael S. Tsirkin wrote: > On Tue, Feb 21, 2017 at 10:58:05AM +0100, Laszlo Ersek wrote: >> On 02/21/17 02:43, Michael S. Tsirkin wrote: >>> On Mon, Feb 20, 2017 at 09:55:40PM +0100, Laszlo Ersek wrote: On 02/20/17 21:45, Eric Blake wrote: > On 02/20/2017 02:19 PM, Dr.

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2017 at 10:58:05AM +0100, Laszlo Ersek wrote: > On 02/21/17 02:43, Michael S. Tsirkin wrote: > > On Mon, Feb 20, 2017 at 09:55:40PM +0100, Laszlo Ersek wrote: > >> On 02/20/17 21:45, Eric Blake wrote: > >>> On 02/20/2017 02:19 PM, Dr. David Alan Gilbert wrote: > * Eric Blake (e

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-21 Thread Laszlo Ersek
On 02/21/17 02:43, Michael S. Tsirkin wrote: > On Mon, Feb 20, 2017 at 09:55:40PM +0100, Laszlo Ersek wrote: >> On 02/20/17 21:45, Eric Blake wrote: >>> On 02/20/2017 02:19 PM, Dr. David Alan Gilbert wrote: * Eric Blake (ebl...@redhat.com) wrote: > On 02/20/2017 04:23 AM, Dr. David Alan Gi

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Michael S. Tsirkin
On Mon, Feb 20, 2017 at 09:55:40PM +0100, Laszlo Ersek wrote: > On 02/20/17 21:45, Eric Blake wrote: > > On 02/20/2017 02:19 PM, Dr. David Alan Gilbert wrote: > >> * Eric Blake (ebl...@redhat.com) wrote: > >>> On 02/20/2017 04:23 AM, Dr. David Alan Gilbert wrote: > * Laszlo Ersek (ler...@redha

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Laszlo Ersek
On 02/20/17 21:19, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: >> On 02/20/2017 04:23 AM, Dr. David Alan Gilbert wrote: >>> * Laszlo Ersek (ler...@redhat.com) wrote: CC Dave >>> >>> This isn't an area I really understand; but if I'm >>> reading this right then >>>

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Laszlo Ersek
On 02/20/17 21:45, Eric Blake wrote: > On 02/20/2017 02:19 PM, Dr. David Alan Gilbert wrote: >> * Eric Blake (ebl...@redhat.com) wrote: >>> On 02/20/2017 04:23 AM, Dr. David Alan Gilbert wrote: * Laszlo Ersek (ler...@redhat.com) wrote: > CC Dave This isn't an area I really unders

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Eric Blake
On 02/20/2017 02:19 PM, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: >> On 02/20/2017 04:23 AM, Dr. David Alan Gilbert wrote: >>> * Laszlo Ersek (ler...@redhat.com) wrote: CC Dave >>> >>> This isn't an area I really understand; but if I'm >>> reading this right then

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 02/20/2017 04:23 AM, Dr. David Alan Gilbert wrote: > > * Laszlo Ersek (ler...@redhat.com) wrote: > >> CC Dave > > > > This isn't an area I really understand; but if I'm > > reading this right then > >vmgenid is stored in fw_cfg? > >fw_cfg isn't

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Eric Blake
On 02/20/2017 04:23 AM, Dr. David Alan Gilbert wrote: > * Laszlo Ersek (ler...@redhat.com) wrote: >> CC Dave > > This isn't an area I really understand; but if I'm > reading this right then >vmgenid is stored in fw_cfg? >fw_cfg isn't migrated > > So why should any changes to it get migra

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Laszlo Ersek
So Igor has now confirmed he's fine with v8 (thanks!), but I still wanted to respond here: On 02/20/17 13:32, Dr. David Alan Gilbert wrote: > * Laszlo Ersek (ler...@redhat.com) wrote: >> On 02/20/17 12:00, Dr. David Alan Gilbert wrote: >>> * Laszlo Ersek (ler...@redhat.com) wrote: On 02/20/17

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Igor Mammedov
On Mon, 20 Feb 2017 14:28:11 +0100 Laszlo Ersek wrote: > On 02/20/17 14:13, Igor Mammedov wrote: > > On Mon, 20 Feb 2017 12:38:06 +0100 > > Laszlo Ersek wrote: [...] > >> Interesting! I hope Igor can double-check this! > > I've retested v7, and it reliably fails (vmgenid_wait doesn't see chang

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Laszlo Ersek
On 02/20/17 14:13, Igor Mammedov wrote: > On Mon, 20 Feb 2017 12:38:06 +0100 > Laszlo Ersek wrote: > >> On 02/20/17 12:00, Dr. David Alan Gilbert wrote: >>> * Laszlo Ersek (ler...@redhat.com) wrote: On 02/20/17 11:23, Dr. David Alan Gilbert wrote: > * Laszlo Ersek (ler...@redhat.com)

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Igor Mammedov
On Mon, 20 Feb 2017 12:38:06 +0100 Laszlo Ersek wrote: > On 02/20/17 12:00, Dr. David Alan Gilbert wrote: > > * Laszlo Ersek (ler...@redhat.com) wrote: > >> On 02/20/17 11:23, Dr. David Alan Gilbert wrote: > >>> * Laszlo Ersek (ler...@redhat.com) wrote: > CC Dave > >>> > >>> This isn

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Dr. David Alan Gilbert
* Laszlo Ersek (ler...@redhat.com) wrote: > On 02/20/17 12:00, Dr. David Alan Gilbert wrote: > > * Laszlo Ersek (ler...@redhat.com) wrote: > >> On 02/20/17 11:23, Dr. David Alan Gilbert wrote: > >>> * Laszlo Ersek (ler...@redhat.com) wrote: > CC Dave > >>> > >>> This isn't an area I really und

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Laszlo Ersek
On 02/20/17 12:00, Dr. David Alan Gilbert wrote: > * Laszlo Ersek (ler...@redhat.com) wrote: >> On 02/20/17 11:23, Dr. David Alan Gilbert wrote: >>> * Laszlo Ersek (ler...@redhat.com) wrote: CC Dave >>> >>> This isn't an area I really understand; but if I'm >>> reading this right then >>>

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Dr. David Alan Gilbert
* Laszlo Ersek (ler...@redhat.com) wrote: > On 02/20/17 11:23, Dr. David Alan Gilbert wrote: > > * Laszlo Ersek (ler...@redhat.com) wrote: > >> CC Dave > > > > This isn't an area I really understand; but if I'm > > reading this right then > >vmgenid is stored in fw_cfg? > >fw_cfg isn't mi

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Laszlo Ersek
On 02/20/17 11:23, Dr. David Alan Gilbert wrote: > * Laszlo Ersek (ler...@redhat.com) wrote: >> CC Dave > > This isn't an area I really understand; but if I'm > reading this right then >vmgenid is stored in fw_cfg? >fw_cfg isn't migrated > > So why should any changes to it get migrated,

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Dr. David Alan Gilbert
* Laszlo Ersek (ler...@redhat.com) wrote: > CC Dave This isn't an area I really understand; but if I'm reading this right then vmgenid is stored in fw_cfg? fw_cfg isn't migrated So why should any changes to it get migrated, except if it's already been read by the guest (and if the guest re

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Ben Warren
> On Feb 17, 2017, at 12:07 PM, Laszlo Ersek wrote: > > On 02/17/17 17:03, Laszlo Ersek wrote: >> On 02/17/17 16:33, Ben Warren wrote: >>> On Feb 17, 2017, at 2:43 AM, Igor Mammedov >>> > wrote: On Thu, 16 Feb 2017 15:15:36 -0800 b...@skyportsyst

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Laszlo Ersek
On 02/17/17 19:34, Ben Warren wrote: > >> On Feb 17, 2017, at 8:03 AM, Laszlo Ersek > > wrote: >> >> On 02/17/17 16:33, Ben Warren wrote: >>> On Feb 17, 2017, at 2:43 AM, Igor Mammedov >>> > wrote: >>

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Laszlo Ersek
On 02/17/17 17:03, Laszlo Ersek wrote: > On 02/17/17 16:33, Ben Warren wrote: >> >>> On Feb 17, 2017, at 2:43 AM, Igor Mammedov >> > wrote: >>> >>> On Thu, 16 Feb 2017 15:15:36 -0800 >>> b...@skyportsystems.com wrote: >>> From: Ben W

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Michael S. Tsirkin
On Fri, Feb 17, 2017 at 10:34:29AM -0800, Ben Warren wrote: > > On Feb 17, 2017, at 8:03 AM, Laszlo Ersek wrote: > > On 02/17/17 16:33, Ben Warren wrote: > > > > On Feb 17, 2017, at 2:43 AM, Igor Mammedov > wrote: > > O

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Ben Warren
> On Feb 17, 2017, at 8:03 AM, Laszlo Ersek wrote: > > On 02/17/17 16:33, Ben Warren wrote: >> >>> On Feb 17, 2017, at 2:43 AM, Igor Mammedov >> >>> >> wrote: >>> >>> On Thu, 16 Feb 2017 15:15:36 -0800 >>> b..

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Laszlo Ersek
On 02/17/17 16:33, Ben Warren wrote: > >> On Feb 17, 2017, at 2:43 AM, Igor Mammedov > > wrote: >> >> On Thu, 16 Feb 2017 15:15:36 -0800 >> b...@skyportsystems.com wrote: >> >>> From: Ben Warren mailto:b...@skyportsystems.com>> >>> >>> T

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Ben Warren
> On Feb 17, 2017, at 2:43 AM, Igor Mammedov wrote: > > On Thu, 16 Feb 2017 15:15:36 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren >> >> This implements the VM Generation ID feature by passing a 128-bit >> GUID to the guest via a fw_cfg blob. >> Any time the GUID changes, an AC

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Laszlo Ersek
On 02/17/17 14:05, Igor Mammedov wrote: > On Fri, 17 Feb 2017 13:50:40 +0100 > Laszlo Ersek wrote: > >> CC Dave >> >> On 02/17/17 11:43, Igor Mammedov wrote: >>> On Thu, 16 Feb 2017 15:15:36 -0800 >>> b...@skyportsystems.com wrote: >>> From: Ben Warren This implements the VM Gener

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Igor Mammedov
On Fri, 17 Feb 2017 13:50:40 +0100 Laszlo Ersek wrote: > CC Dave > > On 02/17/17 11:43, Igor Mammedov wrote: > > On Thu, 16 Feb 2017 15:15:36 -0800 > > b...@skyportsystems.com wrote: > > > >> From: Ben Warren > >> > >> This implements the VM Generation ID feature by passing a 128-bit > >> GUID

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Laszlo Ersek
CC Dave On 02/17/17 11:43, Igor Mammedov wrote: > On Thu, 16 Feb 2017 15:15:36 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren >> >> This implements the VM Generation ID feature by passing a 128-bit >> GUID to the guest via a fw_cfg blob. >> Any time the GUID changes, an ACPI notify

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Igor Mammedov
On Thu, 16 Feb 2017 15:15:36 -0800 b...@skyportsystems.com wrote: > From: Ben Warren > > This implements the VM Generation ID feature by passing a 128-bit > GUID to the guest via a fw_cfg blob. > Any time the GUID changes, an ACPI notify event is sent to the guest > > The user interface is a si

[Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-16 Thread ben
From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. Any time the GUID changes, an ACPI notify event is sent to the guest The user interface is a simple device with one parameter: - guid (string, must be "auto" or in UUID format