Re: [Qemu-devel] [PATCH v8 31/35] qapi: Rework deallocation of partial struct

2016-01-05 Thread Marc-André Lureau
Hi On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote: > Commit cee2dedb noticed that if you have a partial flat union > (such as if an input parse failed due to a missing > discriminator), calling the dealloc visitor could result in > trying to dereference the NULL pointer. But the fix it propose

[Qemu-devel] [PATCH v8 31/35] qapi: Rework deallocation of partial struct

2015-12-21 Thread Eric Blake
Commit cee2dedb noticed that if you have a partial flat union (such as if an input parse failed due to a missing discriminator), calling the dealloc visitor could result in trying to dereference the NULL pointer. But the fix it proposed requires the use of a 'data' member in the union, which may or