Re: [Qemu-devel] [PATCH v8 3/3] ich9: implement strap SPKR pin logic

2015-07-01 Thread Paolo Bonzini
On 02/07/2015 03:30, Paulo Alcantara wrote: > No, the iTCO_wdt driver won't fail to start. It actually depends on > whether RCBA BAR is set. However, ICH9 will just ignore whether > NO_REBOOT is set or unset when SPKR pin is high. This is the code I was referring to, in iTCO_wdt_start:

Re: [Qemu-devel] [PATCH v8 3/3] ich9: implement strap SPKR pin logic

2015-07-01 Thread Paulo Alcantara
On Wed, 1 Jul 2015 15:31:31 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jul 01, 2015 at 03:18:41PM +0200, Paolo Bonzini wrote: > > > > > > On 28/06/2015 19:58, Paulo Alcantara wrote: > > > If the signal is sampled high, this indicates that the system is > > > strapped to the "No Reboot" mode (I

Re: [Qemu-devel] [PATCH v8 3/3] ich9: implement strap SPKR pin logic

2015-07-01 Thread Paolo Bonzini
On 01/07/2015 15:31, Michael S. Tsirkin wrote: > I don't think we should defer the whole series because of the argument > about the default. I've merged these patches, I you like, pls send a > one-line patch on top to flip the default with some info on how it was > tested, and we can discuss it

Re: [Qemu-devel] [PATCH v8 3/3] ich9: implement strap SPKR pin logic

2015-07-01 Thread Michael S. Tsirkin
On Wed, Jul 01, 2015 at 03:18:41PM +0200, Paolo Bonzini wrote: > > > On 28/06/2015 19:58, Paulo Alcantara wrote: > > If the signal is sampled high, this indicates that the system is > > strapped to the "No Reboot" mode (ICH9 will disable the TCO Timer system > > reboot feature). The status of thi

Re: [Qemu-devel] [PATCH v8 3/3] ich9: implement strap SPKR pin logic

2015-07-01 Thread Paolo Bonzini
On 28/06/2015 19:58, Paulo Alcantara wrote: > If the signal is sampled high, this indicates that the system is > strapped to the "No Reboot" mode (ICH9 will disable the TCO Timer system > reboot feature). The status of this strap is readable via the NO_REBOOT > bit (CC: offset 0x3410:bit 5). > >

[Qemu-devel] [PATCH v8 3/3] ich9: implement strap SPKR pin logic

2015-06-28 Thread Paulo Alcantara
If the signal is sampled high, this indicates that the system is strapped to the "No Reboot" mode (ICH9 will disable the TCO Timer system reboot feature). The status of this strap is readable via the NO_REBOOT bit (CC: offset 0x3410:bit 5). The NO_REBOOT bit is set when SPKR pin on ICH9 is sampled