Re: [Qemu-devel] [PATCH v8 3/3] Add optionrom compatible with fw_cfg DMA version

2016-05-23 Thread Richard W.M. Jones
On Mon, May 23, 2016 at 05:05:15PM +0200, Paolo Bonzini wrote: > > > On 11/05/2016 23:06, Richard W.M. Jones wrote: > > From: Marc Marí > > > > This optionrom is based on linuxboot.S. > > > > Signed-off-by: Marc Marí > > Signed-off-by: Richard W.M. Jones > > Hmm, I hadn't noticed that you a

Re: [Qemu-devel] [PATCH v8 3/3] Add optionrom compatible with fw_cfg DMA version

2016-05-23 Thread Paolo Bonzini
On 11/05/2016 23:06, Richard W.M. Jones wrote: > From: Marc Marí > > This optionrom is based on linuxboot.S. > > Signed-off-by: Marc Marí > Signed-off-by: Richard W.M. Jones Hmm, I hadn't noticed that you added -m16. That breaks on even not-too-old GCC (such as 4.8 on RHEL/CentOS 7). Can y

[Qemu-devel] [PATCH v8 3/3] Add optionrom compatible with fw_cfg DMA version

2016-05-11 Thread Richard W.M. Jones
From: Marc Marí This optionrom is based on linuxboot.S. Signed-off-by: Marc Marí Signed-off-by: Richard W.M. Jones --- .gitignore| 4 + hw/i386/pc.c | 10 +- hw/nvram/fw_cfg.c | 2 +- include/hw/nvram/fw_cfg.h | 1 +