Re: [Qemu-devel] [PATCH v8 24/27] target-arm: make VBAR banked

2014-11-03 Thread Peter Maydell
On 3 November 2014 22:06, Greg Bellows wrote: > You seem to not be a fan of the fields setting moved around and Fabian > appears to have done this in a number of places. I left them as is because > I found the changes to add consistency and compactness. I particularly dislike it where it makes t

Re: [Qemu-devel] [PATCH v8 24/27] target-arm: make VBAR banked

2014-11-03 Thread Greg Bellows
You seem to not be a fan of the fields setting moved around and Fabian appears to have done this in a number of places. I left them as is because I found the changes to add consistency and compactness. Would you like me to undo any such changes? Greg On 31 October 2014 12:22, Peter Maydell wro

Re: [Qemu-devel] [PATCH v8 24/27] target-arm: make VBAR banked

2014-10-31 Thread Peter Maydell
On 30 October 2014 21:28, Greg Bellows wrote: > When EL3 is running in Aarch32 (or ARMv7 with Security Extensions) > VBAR has a secure and a non-secure instance, which are mapped to > VBAR_EL1 and VBAR_EL3. > > Signed-off-by: Greg Bellows > > --- > > v5 -> v6 > - Changed _el field variants to be

[Qemu-devel] [PATCH v8 24/27] target-arm: make VBAR banked

2014-10-31 Thread Greg Bellows
When EL3 is running in Aarch32 (or ARMv7 with Security Extensions) VBAR has a secure and a non-secure instance, which are mapped to VBAR_EL1 and VBAR_EL3. Signed-off-by: Greg Bellows --- v5 -> v6 - Changed _el field variants to be array based - Merged VBAR and VBAR_EL1 reginfo entries v3 -> v4