Re: [Qemu-devel] [PATCH v8 1/6] monitor: Suspend monitor instead dropping commands

2018-09-28 Thread Peter Xu
On Fri, Sep 28, 2018 at 03:53:18PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Sep 5, 2018 at 10:24 AM Peter Xu wrote: > > > > When a QMP client sends in-band commands more quickly that we can > > process them, we can either queue them without limit (QUEUE), drop > > commands when the queue

Re: [Qemu-devel] [PATCH v8 1/6] monitor: Suspend monitor instead dropping commands

2018-09-28 Thread Marc-André Lureau
Hi On Wed, Sep 5, 2018 at 10:24 AM Peter Xu wrote: > > When a QMP client sends in-band commands more quickly that we can > process them, we can either queue them without limit (QUEUE), drop > commands when the queue is full (DROP), or suspend receiving commands > when the queue is full (SUSPEND).

[Qemu-devel] [PATCH v8 1/6] monitor: Suspend monitor instead dropping commands

2018-09-04 Thread Peter Xu
When a QMP client sends in-band commands more quickly that we can process them, we can either queue them without limit (QUEUE), drop commands when the queue is full (DROP), or suspend receiving commands when the queue is full (SUSPEND). None of them is ideal: * QUEUE lets a misbehaving client mak